New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unignore settings in testWithApplicationSettings. #677

Merged
merged 3 commits into from Mar 7, 2018

Conversation

Projects
None yet
2 participants
@jkarni
Contributor

jkarni commented Mar 6, 2018

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)
@snoyberg

This comment has been minimized.

Member

snoyberg commented Mar 6, 2018

Good catch! Can you add a note to the ChangeLog about this as well?

@jkarni

This comment has been minimized.

Contributor

jkarni commented Mar 7, 2018

Updated!

@snoyberg

Thanks!

@snoyberg snoyberg merged commit 638a446 into yesodweb:master Mar 7, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@jkarni jkarni deleted the jkarni:jkarni/fixTestWithApplcationSettings branch Mar 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment