New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warp: Log real requests when app throws an error. #698

Merged
merged 2 commits into from Jul 15, 2018

Conversation

Projects
None yet
2 participants
@ChickenProp
Contributor

ChickenProp commented Jul 14, 2018

Previously, in this situation the logger would be passed a dummy
request, with no path or method data. Now the logger sees the actual
request, and can log it appropriately.

Before submitting your PR, check that you've:

  • Bumped the version number

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

ChickenProp added some commits Jul 14, 2018

Warp: Log real requests when app throws an error.
Previously, in this situation the logger would be passed a dummy
request, with no path or method data. Now the logger sees the actual
request, and can log it appropriately.
@snoyberg

Thanks!

@snoyberg snoyberg merged commit 89f81ce into yesodweb:master Jul 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment