Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Network.HTTP2.Server. #754

Merged
merged 1 commit into from Jun 24, 2019

Conversation

@kazu-yamamoto
Copy link
Contributor

kazu-yamamoto commented Jun 21, 2019

I have extracted HTTP/2 implementation in warp and moved it to Network.HTTP2.Server in http2. This results in so beautiful APIs and I feel it's promising. It is independent from WAI hoping that other HTTP engines can use it. http2 version 2.0.0 has been already released.

This PR deletes many modules relating to HTTP/2 and uses Network.HTTP2.Server. This implementation passes all tests on my local machine including h2spec. Field testing has been done at least two weeks in my web site.

@snoyberg This PR is to telling Warp guys that a big change is coming. Please give a look and tell me if you find something wrong.

@kazu-yamamoto kazu-yamamoto requested a review from snoyberg Jun 21, 2019
@kazu-yamamoto

This comment has been minimized.

Copy link
Contributor Author

kazu-yamamoto commented Jun 21, 2019

@kazu-yamamoto

This comment has been minimized.

Copy link
Contributor Author

kazu-yamamoto commented Jun 21, 2019

@snoyberg

This comment has been minimized.

Copy link
Member

snoyberg commented Jun 23, 2019

I didn't look that thoroughly, but a cursory review looks fine to me. I'm happy with this kind of direction too, thanks for pursuing it. If you're comfortable with it, I'd say go ahead with such a release.

kazu-yamamoto added a commit to kazu-yamamoto/wai that referenced this pull request Jun 24, 2019
@kazu-yamamoto kazu-yamamoto force-pushed the kazu-yamamoto:http2-server branch from 74a2228 to 2e21fe3 Jun 24, 2019
kazu-yamamoto added a commit to kazu-yamamoto/wai that referenced this pull request Jun 24, 2019
@kazu-yamamoto kazu-yamamoto merged commit 2e21fe3 into yesodweb:master Jun 24, 2019
0 of 19 checks passed
0 of 19 checks passed
yesodweb.wai Build #20190624.1 failed
Details
yesodweb.wai (Linux cabal-7.10.3) Linux cabal-7.10.3 failed
Details
yesodweb.wai (Linux cabal-8.0.2) Linux cabal-8.0.2 failed
Details
yesodweb.wai (Linux cabal-8.2.2) Linux cabal-8.2.2 failed
Details
yesodweb.wai (Linux cabal-8.4.4) Linux cabal-8.4.4 failed
Details
yesodweb.wai (Linux cabal-8.6.4) Linux cabal-8.6.4 failed
Details
yesodweb.wai (Linux stack-def) Linux stack-def failed
Details
yesodweb.wai (Linux stack-lts-11) Linux stack-lts-11 failed
Details
yesodweb.wai (Linux stack-lts-12) Linux stack-lts-12 failed
Details
yesodweb.wai (Linux stack-lts-13) Linux stack-lts-13 failed
Details
yesodweb.wai (Linux stack-lts-6) Linux stack-lts-6 failed
Details
yesodweb.wai (Linux stack-lts-9) Linux stack-lts-9 failed
Details
yesodweb.wai (Windows stack-lts-13) Windows stack-lts-13 failed
Details
yesodweb.wai (macOS stack-def) macOS stack-def failed
Details
yesodweb.wai (macOS stack-lts-11) macOS stack-lts-11 failed
Details
yesodweb.wai (macOS stack-lts-12) macOS stack-lts-12 failed
Details
yesodweb.wai (macOS stack-lts-13) macOS stack-lts-13 failed
Details
yesodweb.wai (macOS stack-lts-6) macOS stack-lts-6 failed
Details
yesodweb.wai (macOS stack-lts-9) macOS stack-lts-9 failed
Details
@kazu-yamamoto kazu-yamamoto deleted the kazu-yamamoto:http2-server branch Jun 24, 2019
@kazu-yamamoto

This comment has been minimized.

Copy link
Contributor Author

kazu-yamamoto commented Jun 24, 2019

Thank you for reviewing!
Rebased and merged.

@kazu-yamamoto

This comment has been minimized.

Copy link
Contributor Author

kazu-yamamoto commented Jun 24, 2019

@snoyberg I'm trying to fix tests on Azure CI.
Since doctest fails even on my local machine at this moment, I disabled it.
Now only Linux cabal-7.10.3 fails.
Would you give a look?
Because I think that this is not due to the HTTP/2 server library, I will release a new version of warp.

@snoyberg

This comment has been minimized.

Copy link
Member

snoyberg commented Jun 24, 2019

Looks like it's a problem of old Cabal versions not liking the Strict and StrictData extensions for upload to Hackage. I'll try to put in a workaround.

@kazu-yamamoto

This comment has been minimized.

Copy link
Contributor Author

kazu-yamamoto commented Jun 24, 2019

I saw green! Thank you very much!

@snoyberg

This comment has been minimized.

Copy link
Member

snoyberg commented Jun 24, 2019

My pleasure, thanks for all the other fixes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.