New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent indentation in Hamlet files #50

Closed
MaxGabriel opened this Issue Jan 2, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@MaxGabriel
Member

MaxGabriel commented Jan 2, 2015

homepage.hamlet uses 2 space indentation, whereas default-layout-wrapper.hamlet and default-layout.hamlet use 4 space indentation.

It seems inconsistent to use different spacing in the same scaffolded project, and makes it harder for a beginner to know which convention to prefer.

@gregwebs

This comment has been minimized.

Show comment
Hide comment
@gregwebs

gregwebs Jan 2, 2015

Member

Consistency is good. I like 2 spaces for hamlet because unlike Haskell code you can't necessarily restructure it to avoid indentation.

Member

gregwebs commented Jan 2, 2015

Consistency is good. I like 2 spaces for hamlet because unlike Haskell code you can't necessarily restructure it to avoid indentation.

@snoyberg

This comment has been minimized.

Show comment
Hide comment
@snoyberg

snoyberg Jan 2, 2015

Member

I agree with consistency as well. I typically use 4 spaces everywhere, but I don't have a strong feeling on the matter, so I'm happy to go with @gregwebs suggestion.

@MaxGabriel interested in sending a pull request?

Member

snoyberg commented Jan 2, 2015

I agree with consistency as well. I typically use 4 spaces everywhere, but I don't have a strong feeling on the matter, so I'm happy to go with @gregwebs suggestion.

@MaxGabriel interested in sending a pull request?

@MaxGabriel

This comment has been minimized.

Show comment
Hide comment
@MaxGabriel

MaxGabriel Jan 2, 2015

Member

I like 2 spaces as well; I'll make a PR for it.

Unless you guys want to go with a 3 space compromise? ;)

Member

MaxGabriel commented Jan 2, 2015

I like 2 spaces as well; I'll make a PR for it.

Unless you guys want to go with a 3 space compromise? ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment