New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimal should depend on yesod-core and import Yesod.Core #65

Closed
pbrisbin opened this Issue Feb 23, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@pbrisbin
Member

pbrisbin commented Feb 23, 2015

I love the minimal branch for getting folks up and running with a small, understandable scaffold. Unfortunately compiling all of the yesod package is time consuming. Only yesod-core is needed to run this scaffold. All that's needed is to update build-depends to yesod-core and import Yesod.Core instead in all the hs files.

@gregwebs

This comment has been minimized.

Show comment
Hide comment
@gregwebs

gregwebs Feb 24, 2015

Member

Now that we no longer recommend yesod-platform there is a lot of benefit to this. Want to send a pull request for it?

Member

gregwebs commented Feb 24, 2015

Now that we no longer recommend yesod-platform there is a lot of benefit to this. Want to send a pull request for it?

@pbrisbin

This comment has been minimized.

Show comment
Hide comment
@pbrisbin

pbrisbin Feb 24, 2015

Member

I have one ready but I'm getting permission denied pushing my branch to this repo. I don't mind making my own fork, but being in the Org, I expected to be able to... any ideas?

Member

pbrisbin commented Feb 24, 2015

I have one ready but I'm getting permission denied pushing my branch to this repo. I don't mind making my own fork, but being in the Org, I expected to be able to... any ideas?

@gregwebs

This comment has been minimized.

Show comment
Hide comment
@gregwebs

gregwebs Feb 24, 2015

Member

Sorry, it still had default settings. You should be able to push now.

Member

gregwebs commented Feb 24, 2015

Sorry, it still had default settings. You should be able to push now.

pbrisbin added a commit that referenced this issue Feb 24, 2015

@pbrisbin

This comment has been minimized.

Show comment
Hide comment
@pbrisbin

pbrisbin Feb 24, 2015

Member

Awesome thanks. PR opened.

Member

pbrisbin commented Feb 24, 2015

Awesome thanks. PR opened.

@snoyberg snoyberg closed this Feb 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment