Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error provenance for stuff invoking withResponse' #1191

Merged
merged 4 commits into from Mar 21, 2016

Conversation

@bitemyapp
Copy link
Contributor

commented Mar 17, 2016

I tried to take a light touch, mostly mucking with the prime variants of functions.

Here's how it looks:

screenshot from 2016-03-17 14-35-08

This is intended to resolve #1185

@codygman

This comment has been minimized.

Copy link

commented Mar 17, 2016

👍 Seems like an improvement to me.

@bitemyapp

This comment has been minimized.

Copy link
Contributor Author

commented Mar 18, 2016

The test failure seems spurious, could be wrong.

@@ -1,5 +1,5 @@
name: yesod-test
version: 1.5.0.1
version: 1.6.0.0

This comment has been minimized.

Copy link
@snoyberg

snoyberg Mar 20, 2016

Member

What's the reason for the major version bump? It looks like this only changes internal functions.

This comment has been minimized.

Copy link
@bitemyapp

bitemyapp Mar 20, 2016

Author Contributor

Oh so it does. I'd managed that on accident, thinking I'd changed the type signature of something that was exported. Nuts. I'll fix it, sorry!

snoyberg added a commit that referenced this pull request Mar 21, 2016
Merge pull request #1191 from bitemyapp/master
Better error provenance for stuff invoking withResponse'

@snoyberg snoyberg merged commit 5cf7694 into yesodweb:master Mar 21, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@snoyberg

This comment has been minimized.

Copy link
Member

commented Mar 21, 2016

Thanks Chris!

snoyberg added a commit that referenced this pull request Mar 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.