Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added assertEq, deprecated assertEqual #1259

Merged
merged 1 commit into from Aug 10, 2016

Conversation

@bitemyapp
Copy link
Contributor

commented Aug 10, 2016

For #1255

"First argument: " ++ ppShow a ++ "\n" ++
"Second argument: " ++ ppShow b ++ "\n"

{-# DEPRECATED assertEqual "Use assertEqual instead" #-}

This comment has been minimized.

Copy link
@snoyberg

snoyberg Aug 10, 2016

Member

Did you mean Use assertEq instead?

This comment has been minimized.

Copy link
@bitemyapp

bitemyapp Aug 10, 2016

Author Contributor

@snoyberg quite right! Forgot to amend it after I figured out the name.

Added assertEq, deprecated assertEqual
use assertEq instead
@@ -14,29 +14,30 @@ description: API docs and the README are available at <http://www.stackage.o
extra-source-files: README.md, LICENSE, test/main.hs, ChangeLog.md

library
build-depends: base >= 4.3 && < 5

This comment has been minimized.

Copy link
@snoyberg

snoyberg Aug 10, 2016

Member

Were the edits to this file intentional?

This comment has been minimized.

Copy link
@bitemyapp

bitemyapp Aug 10, 2016

Author Contributor

@snoyberg yes, my eyes swam checking for something, so I fired my re-ordering function on it. I can remove it if you like.

This comment has been minimized.

Copy link
@snoyberg

snoyberg Aug 10, 2016

Member

Generally I keep such changes separate, but not a big deal. I'll merge once Travis goes green.

@snoyberg snoyberg merged commit 13d9f58 into yesodweb:master Aug 10, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
snoyberg added a commit that referenced this pull request Aug 10, 2016
@bitemyapp bitemyapp referenced this pull request Aug 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.