Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bodyNotContains function #1271

Merged
merged 4 commits into from Sep 1, 2016

Conversation

@amitaibu
Copy link
Contributor

commented Sep 1, 2016

PR adds a function to assert a text doesn't appear in the body of the response

@@ -395,6 +395,13 @@ bodyContains text = withResponse $ \ res ->
liftIO $ HUnit.assertBool ("Expected body to contain " ++ text) $
(simpleBody res) `contains` text

-- | Assert the last response doesn't have the given text. The check is performed using the response
-- body in full text form.

This comment has been minimized.

Copy link
@snoyberg

snoyberg Sep 1, 2016

Member

Can you add a @since comment, as well as bump the .cabal version field and add a comment to the ChangeLog.md? This looks good.

This comment has been minimized.

Copy link
@snoyberg

snoyberg Sep 1, 2016

Member

Oh, also need to export the identifier from the module.

amitaibu added 2 commits Sep 1, 2016
@snoyberg

This comment has been minimized.

Copy link
Member

commented Sep 1, 2016

The build fails on Travis.

@amitaibu

This comment has been minimized.

Copy link
Contributor Author

commented Sep 1, 2016

Tests seem to be fixed apart of one that is stuck. Maybe we should restart that test?

build__2106_-yesodweb_yesod-_travis_ci

@snoyberg

This comment has been minimized.

Copy link
Member

commented Sep 1, 2016

Restarted

@snoyberg snoyberg merged commit 33fd9de into yesodweb:master Sep 1, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@amitaibu

This comment has been minimized.

Copy link
Contributor Author

commented Sep 1, 2016

The failing environment seems like it didn't restart. Should we move it to allowed failings?

@psibi

This comment has been minimized.

Copy link
Member

commented Sep 1, 2016

@snoyberg

This comment has been minimized.

Copy link
Member

commented Sep 1, 2016

I merged to master since all seems to be in order. We'll see if it breaks the master build too somehow.

@amitaibu

This comment has been minimized.

Copy link
Contributor Author

commented Sep 1, 2016

Cool, thanks folks. Excited about my first yesod core PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.