New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yesod-bin: Make it build with latest optparse-applicative #1282

Merged
merged 1 commit into from Sep 28, 2016

Conversation

Projects
None yet
2 participants
@erikd
Contributor

erikd commented Sep 27, 2016

Also bump dependency lower bound.

@snoyberg

This comment has been minimized.

Show comment
Hide comment
@snoyberg

snoyberg Sep 27, 2016

Member

I'd rather keep compatibility with older versions. Would it be possible to update this with a CPP approach?

Member

snoyberg commented Sep 27, 2016

I'd rather keep compatibility with older versions. Would it be possible to update this with a CPP approach?

@erikd

This comment has been minimized.

Show comment
Hide comment
@erikd

erikd Sep 27, 2016

Contributor

According to Travis, the latest optparse-applicative makes the cabal constraint solver fail, so maybe an upper bound makes more sense.

Contributor

erikd commented Sep 27, 2016

According to Travis, the latest optparse-applicative makes the cabal constraint solver fail, so maybe an upper bound makes more sense.

yesod-bin: Make it build with latest optparse-applicative
Done with CPP hackery so the lower bound can remain unchanged.
@erikd

This comment has been minimized.

Show comment
Hide comment
@erikd

erikd Sep 27, 2016

Contributor

I switched to a CPP fix as suggested.

There was one failure:

Codec.Compression.Zlib: compressed data stream format error (incorrect data check)

which has nothing to do with my change.

Contributor

erikd commented Sep 27, 2016

I switched to a CPP fix as suggested.

There was one failure:

Codec.Compression.Zlib: compressed data stream format error (incorrect data check)

which has nothing to do with my change.

@snoyberg

This comment has been minimized.

Show comment
Hide comment
@snoyberg

snoyberg Sep 28, 2016

Member

Awesome, thanks!

Member

snoyberg commented Sep 28, 2016

Awesome, thanks!

@snoyberg snoyberg merged commit 8014208 into yesodweb:master Sep 28, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@snoyberg snoyberg removed the in progress label Sep 28, 2016

snoyberg added a commit that referenced this pull request Sep 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment