Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yesod] Fix comment for contentTypeTypes & simpler implementation #1476

Merged
merged 2 commits into from Feb 2, 2018

Conversation

Projects
None yet
2 participants
@JaSpa
Copy link
Contributor

JaSpa commented Jan 18, 2018

In the implementation of contentTypeTypes there is no need to repeat the logic from simpleContentType which is defined just above it.


Before submitting your PR, check that you've:

  • Bumped the version number

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

JaSpa added some commits Jan 18, 2018

[yesod] Fix comment for contentTypeTypes & simpler implementation
In the implementation of contentTypeTypes make use of simpleContentType.
@snoyberg

This comment has been minimized.

Copy link
Member

snoyberg commented Jan 21, 2018

Thanks, I've merged this into #1464.

@snoyberg snoyberg merged commit 4921025 into yesodweb:master Feb 2, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details

@JaSpa JaSpa deleted the JaSpa:simple-content-type branch Feb 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.