Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generalize type signature of GoogleEmail2.getPerson #1501

Merged
merged 2 commits into from Apr 9, 2018

Conversation

@rnons
Copy link
Contributor

commented Apr 9, 2018

close #1500

Copy link
Member

left a comment

LGTM, I'll just wait for Travis to finish

@snoyberg

This comment has been minimized.

Copy link
Member

commented Apr 9, 2018

Sorry, I forgot to ask: can you apply a minor version bump in the cabal file and add a note to the changelog?

@rnons

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2018

Updated, please check

Copy link
Member

left a comment

Thanks!

@snoyberg snoyberg merged commit 06e0ffb into yesodweb:master Apr 9, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.