Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthEmail: Fix forgot-password endpoint #1537

merged 2 commits into from Jul 10, 2018


None yet
2 participants
Copy link

commented Jul 9, 2018

Currently, defining emailPreviouslyRegisteredResponse will prevent sendConfirmationEmail from happening, even when registerHelper is called from postForgotPasswordR; which effectively disable the forgot password function.
Since this is just a quick fix for #1524, I don't think we need to bump version?

AuthEmail: Fix forgot-password endpoint
This is a quick fix for PR#1524.
Currently, defining `emailPreviouslyRegisteredResponse` will prevent
`sendConfirmationEmail` from happening, even when `registerHelper` is
called from `postForgotPasswordR`.

This comment has been minimized.

Copy link

commented Jul 9, 2018

Since I already released this to Hackage, we will need a patch version bump.


This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2018

I see, just bumped to
Should have done this before the register-password one, sorry.

@snoyberg snoyberg merged commit b7a3385 into yesodweb:master Jul 10, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
continuous-integration/appveyor/pr AppVeyor build succeeded

@kk-hainq kk-hainq deleted the kikaitech:fix_forgot_pass_endpoint branch Jul 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.