Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yesod-test] Add utility functions to modify cookies #1570

Merged
merged 1 commit into from Jan 15, 2019

Conversation

@MaxGabriel
Copy link
Member

commented Jan 15, 2019

So, maybe I missed something obvious, but it seems like the functions to modify the current YesodExampleData are private, and one couldn't modify cookies. I think testing modifying the cookies seems like reasonable functionality to have, because users and browsers can obviously change them.

This is kind of a problem with all of yesod-test having generic names like get, but names like setCookie conflict with ones in Yesod itself. Thoughts on this? I prefixed them with test but maybe prefixing with y is better?

(In our application we've just imported yesod-test qualified, so we don't have this issue)

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@MaxGabriel MaxGabriel force-pushed the cookieHelpers branch from af5790f to bedec86 Jan 15, 2019

@snoyberg
Copy link
Member

left a comment

LGTM, I have no concerns with the naming you've chosen, and agree that the name collisions we already have are unfortunate. Should we merge and release?

@MaxGabriel MaxGabriel merged commit 673db5f into master Jan 15, 2019

3 of 4 checks passed

continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@MaxGabriel

This comment has been minimized.

Copy link
Member Author

commented Jan 15, 2019

Thanks @snoyberg; merged and uploaded!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.