Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clearCreds redirect behavior depends on request type. #1598

Merged
merged 1 commit into from May 24, 2019

Conversation

@StevenXL
Copy link
Member

commented May 14, 2019

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)
@StevenXL StevenXL force-pushed the StevenXL:update-clearcreds branch from f4d0245 to f546414 May 14, 2019
@StevenXL

This comment has been minimized.

Copy link
Member Author

commented May 14, 2019

This is a copy-and-paste from #991. Call credit to @meteficha.

yesod-auth/Yesod/Auth.hs Outdated Show resolved Hide resolved
@StevenXL StevenXL force-pushed the StevenXL:update-clearcreds branch from f546414 to ceeeb16 May 14, 2019
@StevenXL

This comment has been minimized.

Copy link
Member Author

commented May 15, 2019

@snoyberg Not getting much feedback on the failure in CI. Anything I can do?

@snoyberg

This comment has been minimized.

Copy link
Member

commented May 15, 2019

No idea, I've never seen it do that before. I'd ignore it, if it remains after a merge to master we can look into it.

@StevenXL StevenXL merged commit c90c509 into yesodweb:master May 24, 2019
19 of 23 checks passed
19 of 23 checks passed
yesodweb.yesod Build #20190514.3 failed
Details
yesodweb.yesod (macOS stack-lts-11)
Details
yesodweb.yesod (Linux stack-persistent-2-9)
Details
yesodweb.yesod (macOS stack-lts-9)
Details
yesodweb.yesod (Linux cabal-8.0.2) Linux cabal-8.0.2 succeeded
Details
yesodweb.yesod (Linux cabal-8.2.2) Linux cabal-8.2.2 succeeded
Details
yesodweb.yesod (Linux cabal-8.4.4) Linux cabal-8.4.4 succeeded
Details
yesodweb.yesod (Linux cabal-8.6.5) Linux cabal-8.6.5 succeeded
Details
yesodweb.yesod (Linux nightly) Linux nightly succeeded
Details
yesodweb.yesod (Linux pedantic) Linux pedantic succeeded
Details
yesodweb.yesod (Linux stack-def) Linux stack-def succeeded
Details
yesodweb.yesod (Linux stack-lts-11) Linux stack-lts-11 succeeded
Details
yesodweb.yesod (Linux stack-lts-12) Linux stack-lts-12 succeeded
Details
yesodweb.yesod (Linux stack-lts-13) Linux stack-lts-13 succeeded
Details
yesodweb.yesod (Linux stack-lts-9) Linux stack-lts-9 succeeded
Details
yesodweb.yesod (Linux stack-persistent-2-10) Linux stack-persistent-2-10 succeeded
Details
yesodweb.yesod (Windows stack-lts-11) Windows stack-lts-11 succeeded
Details
yesodweb.yesod (Windows stack-lts-12) Windows stack-lts-12 succeeded
Details
yesodweb.yesod (Windows stack-lts-13) Windows stack-lts-13 succeeded
Details
yesodweb.yesod (macOS stack-lts-12) macOS stack-lts-12 succeeded
Details
yesodweb.yesod (macOS stack-lts-13) macOS stack-lts-13 succeeded
Details
yesodweb.yesod (macOS stack-persistent-2-10) macOS stack-persistent-2-10 succeeded
Details
yesodweb.yesod (macOS stack-persistent-2-9) macOS stack-persistent-2-9 succeeded
Details
@StevenXL

This comment has been minimized.

Copy link
Member Author

commented May 24, 2019

@snoyberg Merged to master. Fingers crossed on the errant error.

@StevenXL StevenXL deleted the StevenXL:update-clearcreds branch Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.