Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added functions to simplify application of an ssl-only policy to a site #894

Merged
merged 1 commit into from Dec 20, 2014

Conversation

Projects
None yet
2 participants
@patrickboe
Copy link

patrickboe commented Dec 20, 2014

This is the alternate design to my other pull request on the same topic. This is obviously simpler. No changes are necessary to the scaffolding, since the default behavior of not applying an ssl-only policy is unchanged. As mentioned in the discussion on the other PR, this approach adds a coordinated-configuration burden to scaffolded and default sites in order to avoid the danger, existing in the other design, that a user would define an ssl-only policy on their site but fail to apply it in their customizations.

I assume it's worth changing the text of the yesod book's chapter on sessions to include some note about this, but I'm not sure if that's in a repo I can offer a PR for. Let me know.

@patrickboe

This comment has been minimized.

Copy link
Author

patrickboe commented Dec 20, 2014

Oh, I guess it's yesodweb.com-content

@snoyberg

This comment has been minimized.

Copy link
Member

snoyberg commented Dec 20, 2014

Looks great. I'd certainly accept a pull request to the book as well.

@snoyberg snoyberg merged commit 8b7c58f into yesodweb:master Dec 20, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.