New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade rails to 5.2 #430

Merged
merged 3 commits into from Jan 17, 2019

Conversation

Projects
None yet
3 participants
@gigorok
Copy link
Contributor

gigorok commented Jan 10, 2019

  1. upgrade activeadmin to latest version
  2. use jquery3 instead of jquery2
  3. add bootsnap gem to speedup booting
  4. remove unused css
  5. etc (look at changes)
@@ -22,6 +22,7 @@
@import "font-awesome";
@import "active_admin/components/active_admin_scoped_collection_actions";
@import "vendor/highlightjs/default";
@import "yeti/yeti.css"

This comment has been minimized.

@workgena

workgena Jan 11, 2019

Contributor

This might not work in production-mode.

Recently I've had a problem - CSS files would not be imported(dev-mode works fine).
In case of such error, the solution is to rename files *.css to *.scss.

This comment has been minimized.

@gigorok

gigorok Jan 11, 2019

Contributor

thanks. I'll check it

@gigorok gigorok force-pushed the gigorok:upgrade-rails-5-2 branch 2 times, most recently from b181801 to e45aac5 Jan 11, 2019

@gigorok gigorok changed the title Upgrade rails 5 2 WIP: Upgrade rails 5 2 Jan 13, 2019

@gigorok gigorok force-pushed the gigorok:upgrade-rails-5-2 branch from e45aac5 to 182cdd0 Jan 14, 2019

@gigorok gigorok force-pushed the gigorok:upgrade-rails-5-2 branch from 7170e7f to a857661 Jan 14, 2019

@gigorok gigorok changed the title WIP: Upgrade rails 5 2 upgrade rails to 5.2 Jan 14, 2019

@gigorok gigorok requested a review from dmitry-sinina Jan 14, 2019

@workgena

This comment has been minimized.

Copy link
Contributor

workgena commented Jan 15, 2019

I've did a small check. Unfortunately we do not covered all pages with system tests. So some pages may be broken, even if tests are green 👽

Broken pages, i've noticed(the errors are unfamiliar to me):

  • /gateways/new
  • /dialpeers/new
  • /audit_log_items

Also I did assets:precompile + rails s in production mode, all works fine(js, css).

@gigorok

This comment has been minimized.

Copy link
Contributor

gigorok commented Jan 15, 2019

@workgena what kind of errors did you receive?

@workgena

This comment has been minimized.

Copy link
Contributor

workgena commented Jan 15, 2019

Started GET "/gateways/new" for 127.0.0.1 at 2019-01-15 14:55:29 +0200
Processing by GatewaysController#new as HTML
  AdminUser Load (0.3ms)  SELECT  "admin_users".* FROM "admin_users" WHERE "admin_users"."id" = $1 ORDER BY "admin_users"."id" ASC LIMIT $2  [["id", 3], ["LIMIT", 1]]
  ↳ app/controllers/application_controller.rb:45
Completed 500 Internal Server Error in 2ms

ArgumentError (wrong number of arguments (given 0, expected 1)):
  
config/initializers/instrumentation_notification.rb:28:in `block in process_action'
config/initializers/instrumentation_notification.rb:27:in `process_action'
@gigorok

This comment has been minimized.

Copy link
Contributor

gigorok commented Jan 16, 2019

Started GET "/gateways/new" for 127.0.0.1 at 2019-01-15 14:55:29 +0200
Processing by GatewaysController#new as HTML
  AdminUser Load (0.3ms)  SELECT  "admin_users".* FROM "admin_users" WHERE "admin_users"."id" = $1 ORDER BY "admin_users"."id" ASC LIMIT $2  [["id", 3], ["LIMIT", 1]]
  ↳ app/controllers/application_controller.rb:45
Completed 500 Internal Server Error in 2ms

ArgumentError (wrong number of arguments (given 0, expected 1)):
  
config/initializers/instrumentation_notification.rb:28:in `block in process_action'
config/initializers/instrumentation_notification.rb:27:in `process_action'

related with upgrading of activeadmin. fixed

@dmitry-sinina dmitry-sinina merged commit 9ed7b7a into yeti-switch:master Jan 17, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment