Remove SirenContext implicit parameter for conversion to root entity #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another API-breaking change that I propose to include, but I think it's worth it. It removes the
SirenContext
type from the library altogether, and hence,toSiren
and the other functions no longer have an implicit parameter list with theSirenContext
parameter.The reasoning behind this is that having to provide an implementation of this trait is quite a heavy burden, given that there may be many cases where it is not required at all for conversion to a Siren root entity. Where it is required, the same effect can easily be achieved this way (see the
ExampleSpec
):This way, providing the information like a base URI is left optional to situations where it is required, and it will be less cumbersome to integrate the library with existing web frameworks or libraries, that may have their own way of providing the kind of information transported in the
SirenContext
so far.