Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream yew-router project #1095

Merged
merged 3 commits into from Apr 23, 2020
Merged

Upstream yew-router project #1095

merged 3 commits into from Apr 23, 2020

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented Apr 20, 2020 •
edited

Problem

Yew Router lags behind Yew updates due to being in a separate repo and not having compile checks for the latest changes

Changes

  • Add yew-router and associated crates
  • Add "web_sys" feature to yew-router default features
  • Add CODEOWNERS file

Fixes: #1097
Fixes: #1106

@jstarry jstarry requested a review from hgzimmerman Apr 20, 2020
@jstarry jstarry merged commit 9f286d1 into yewstack:master Apr 23, 2020
1 check passed
@jstarry jstarry deleted the yew-router branch Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hgzimmerman hgzimmerman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a cargo check for target wasm32-unknown-unknown to CI
Ease maintainability by merging into main yew repo
2 participants
@jstarry @hgzimmerman