Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added relevant examples section to the docs #1695

Merged
merged 3 commits into from Jan 23, 2021

Conversation

oOBoomberOo
Copy link
Contributor

@oOBoomberOo oOBoomberOo commented Jan 10, 2021

This draft is for tracking and eventually close #1381

Description

I'm adding links to relevant examples in the docs to help users understand the Yew docs more easily.

Note: I'm making this draft first before finishing it because I would like to hear some feedback on the current link style before I start using it everywhere.

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
  • link to examples from yew.rs pages
  • link to examples from docs.rs pages

IssueHunt Summary

Referenced issues

This pull request has been submitted to:


@github-actions
Copy link

github-actions bot commented Jan 10, 2021

Visit the preview URL for this PR (updated for commit db954b4):

https://yew-rs--pr1695-link-to-examples-ettxc13h.web.app

(expires Sat, 30 Jan 2021 03:23:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@oOBoomberOo
Copy link
Contributor Author

I think I've linked relevant examples to everywhere I can.

@oOBoomberOo oOBoomberOo marked this pull request as ready for review January 17, 2021 07:56
Copy link
Contributor

@teymour-aldridge teymour-aldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for a few (very, very small) nits, LGTM!

docs/concepts/router.md Outdated Show resolved Hide resolved
docs/concepts/components/callbacks.md Outdated Show resolved Hide resolved
docs/concepts/components/refs.md Outdated Show resolved Hide resolved
docs/concepts/html/components.md Outdated Show resolved Hide resolved
docs/concepts/html/lists.md Outdated Show resolved Hide resolved
yew/src/html/mod.rs Outdated Show resolved Hide resolved
@oOBoomberOo
Copy link
Contributor Author

Should be all fixed now :)

@jstarry jstarry merged commit 6f27a74 into yewstack:master Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to examples from relevant sections of Yew docs
3 participants