From e13db426b2e721fca685923918dabb1c80edfa79 Mon Sep 17 00:00:00 2001 From: Emily Zhang Date: Mon, 4 Mar 2024 18:32:29 -0500 Subject: [PATCH 1/3] Resolve more vulnerabilities --- static/js/theme-map/Renderer/ElementRenderTarget.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/static/js/theme-map/Renderer/ElementRenderTarget.js b/static/js/theme-map/Renderer/ElementRenderTarget.js index e8a5c02ac..b9159ee89 100644 --- a/static/js/theme-map/Renderer/ElementRenderTarget.js +++ b/static/js/theme-map/Renderer/ElementRenderTarget.js @@ -47,11 +47,11 @@ class ElementRenderTarget extends RenderTarget { /** * async render(data) => DOMNode - * Calls templateFunction(data) and sets value to element.innerHTML, then returns element + * Calls templateFunction(data) and sets value to element.textContnet, then returns element */ async render(data) { if (this._element) { - this._element.innerHTML = this._templateFunction(data); + this._element.textContnet = this._templateFunction(data); } return this._element; From 05d5961632b0e575d455bc5b971eac285b44f6f3 Mon Sep 17 00:00:00 2001 From: Emily Zhang Date: Tue, 5 Mar 2024 11:25:11 -0500 Subject: [PATCH 2/3] Fix typo --- static/js/theme-map/Renderer/ElementRenderTarget.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/static/js/theme-map/Renderer/ElementRenderTarget.js b/static/js/theme-map/Renderer/ElementRenderTarget.js index b9159ee89..f9e59a72d 100644 --- a/static/js/theme-map/Renderer/ElementRenderTarget.js +++ b/static/js/theme-map/Renderer/ElementRenderTarget.js @@ -51,7 +51,7 @@ class ElementRenderTarget extends RenderTarget { */ async render(data) { if (this._element) { - this._element.textContnet = this._templateFunction(data); + this._element.textContent = this._templateFunction(data); } return this._element; From 56b9f2aad73ae86c2df3c78d002361c78670cda8 Mon Sep 17 00:00:00 2001 From: Emily Zhang Date: Tue, 5 Mar 2024 12:44:39 -0500 Subject: [PATCH 3/3] Fix typo in comment --- static/js/theme-map/Renderer/ElementRenderTarget.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/static/js/theme-map/Renderer/ElementRenderTarget.js b/static/js/theme-map/Renderer/ElementRenderTarget.js index f9e59a72d..d1a146172 100644 --- a/static/js/theme-map/Renderer/ElementRenderTarget.js +++ b/static/js/theme-map/Renderer/ElementRenderTarget.js @@ -47,7 +47,7 @@ class ElementRenderTarget extends RenderTarget { /** * async render(data) => DOMNode - * Calls templateFunction(data) and sets value to element.textContnet, then returns element + * Calls templateFunction(data) and sets value to element.textContent, then returns element */ async render(data) { if (this._element) {