From 10081035126eb4223ed1c6a0ae9e5dd017e97d84 Mon Sep 17 00:00:00 2001 From: Oliver Shi Date: Fri, 28 Jan 2022 09:59:41 -0500 Subject: [PATCH 01/15] add misc tests --- .circleci/config.yml | 2 +- .../run_translation_verification.sh | 8 +++---- .github/workflows/miscellaneous_tests.yml | 23 +++++++++++++++++++ 3 files changed, 28 insertions(+), 5 deletions(-) rename {.circleci => .github}/run_translation_verification.sh (85%) create mode 100644 .github/workflows/miscellaneous_tests.yml diff --git a/.circleci/config.yml b/.circleci/config.yml index 726d7c729..a51c167ab 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -147,7 +147,7 @@ jobs: name: Verify translation files command: | sudo apt-get install -qq gettext - ./.circleci/run_translation_verification.sh + ./.github/run_translation_verification.sh # deploys assets to an uncached folder in the S3 bucket named by branch deploy_branch: docker: diff --git a/.circleci/run_translation_verification.sh b/.github/run_translation_verification.sh similarity index 85% rename from .circleci/run_translation_verification.sh rename to .github/run_translation_verification.sh index aeea97903..4c9b69d3c 100755 --- a/.circleci/run_translation_verification.sh +++ b/.github/run_translation_verification.sh @@ -16,10 +16,10 @@ fi # Verify that translations are present for all languages cd conf/i18n/translations -if [[ $CIRCLE_BRANCH == release/* - || $CIRCLE_BRANCH == hotfix/* - || $CIRCLE_BRANCH == master - || $CIRCLE_BRANCH == support/* ]] +if [[ $GITHUB_REF_NAME == release/* + || $GITHUB_REF_NAME == hotfix/* + || $GITHUB_REF_NAME == master + || $GITHUB_REF_NAME == support/* ]] then for po_file in *.po do msgcmp $po_file messages.pot diff --git a/.github/workflows/miscellaneous_tests.yml b/.github/workflows/miscellaneous_tests.yml new file mode 100644 index 000000000..1e9d517b7 --- /dev/null +++ b/.github/workflows/miscellaneous_tests.yml @@ -0,0 +1,23 @@ +name: Run miscellaneous tests + +on: + workflow_call: + +jobs: + unit_tests: + runs-on: ubuntu-latest + + steps: + - uses: actions/checkout@v2 + - name: Use Node.js 14 + uses: actions/setup-node@v2 + with: + node-version: 14 + cache: 'npm' + - run: npm ci + - name: Download build-output artifact + uses: actions/download-artifact@v2 + with: + name: build-output + path: dist/ + - run: ./.circleci/run_translation_verification.sh \ No newline at end of file From bd19afed934d7c8ef9cc3e856113ebf0f6f9e5ae Mon Sep 17 00:00:00 2001 From: Oliver Shi Date: Fri, 28 Jan 2022 10:03:20 -0500 Subject: [PATCH 02/15] add call --- .github/workflows/build_and_deploy.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/build_and_deploy.yml b/.github/workflows/build_and_deploy.yml index acb02e2e0..7b6002bfc 100644 --- a/.github/workflows/build_and_deploy.yml +++ b/.github/workflows/build_and_deploy.yml @@ -18,6 +18,10 @@ jobs: uses: ./.github/workflows/unit_test.yml needs: call_build + call_misc_test: + uses: ./.github/workflows/miscellaneous_tests.yml + needs: call_build + call_acceptance: uses: ./.github/workflows/acceptance.yml needs: call_build From 507e41f2b3f31cd11992fecf9cf3e12ea959d323 Mon Sep 17 00:00:00 2001 From: Oliver Shi Date: Fri, 28 Jan 2022 10:07:37 -0500 Subject: [PATCH 03/15] fix link --- .github/workflows/miscellaneous_tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/miscellaneous_tests.yml b/.github/workflows/miscellaneous_tests.yml index 1e9d517b7..c19d67f7e 100644 --- a/.github/workflows/miscellaneous_tests.yml +++ b/.github/workflows/miscellaneous_tests.yml @@ -20,4 +20,4 @@ jobs: with: name: build-output path: dist/ - - run: ./.circleci/run_translation_verification.sh \ No newline at end of file + - run: ./.github/run_translation_verification.sh \ No newline at end of file From 42ba59eaa439631391d099c1df8962fac5b3fefe Mon Sep 17 00:00:00 2001 From: Oliver Shi Date: Fri, 28 Jan 2022 10:09:36 -0500 Subject: [PATCH 04/15] doesn't need build --- .github/workflows/build_and_deploy.yml | 5 ++--- .github/workflows/miscellaneous_tests.yml | 5 ----- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/.github/workflows/build_and_deploy.yml b/.github/workflows/build_and_deploy.yml index 7b6002bfc..4fe1243ba 100644 --- a/.github/workflows/build_and_deploy.yml +++ b/.github/workflows/build_and_deploy.yml @@ -17,10 +17,9 @@ jobs: call_unit_test: uses: ./.github/workflows/unit_test.yml needs: call_build - - call_misc_test: + + call_misc_tests: uses: ./.github/workflows/miscellaneous_tests.yml - needs: call_build call_acceptance: uses: ./.github/workflows/acceptance.yml diff --git a/.github/workflows/miscellaneous_tests.yml b/.github/workflows/miscellaneous_tests.yml index c19d67f7e..9f01bd9c9 100644 --- a/.github/workflows/miscellaneous_tests.yml +++ b/.github/workflows/miscellaneous_tests.yml @@ -15,9 +15,4 @@ jobs: node-version: 14 cache: 'npm' - run: npm ci - - name: Download build-output artifact - uses: actions/download-artifact@v2 - with: - name: build-output - path: dist/ - run: ./.github/run_translation_verification.sh \ No newline at end of file From 117ab3688d27d7ee6168781f5442376c29f9238e Mon Sep 17 00:00:00 2001 From: Oliver Shi Date: Fri, 28 Jan 2022 10:15:40 -0500 Subject: [PATCH 05/15] test when translations missing --- conf/i18n/translations/messages.pot | 12 ++++++------ src/ui/templates/results/alternativeverticals.hbs | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/conf/i18n/translations/messages.pot b/conf/i18n/translations/messages.pot index 2124a280d..184de8edf 100644 --- a/conf/i18n/translations/messages.pot +++ b/conf/i18n/translations/messages.pot @@ -42,6 +42,12 @@ msgstr "" msgid "Alternatively, you can view results across all search categories." msgstr "" +#: src/ui/templates/results/alternativeverticals.hbs:11 +msgid "bobob The following search category yielded results for \"[[query]]\":" +msgid_plural "The following search categories yielded results for \"[[query]]\":" +msgstr[0] "" +msgstr[1] "" + #: src/ui/components/questions/questionsubmissioncomponent.js:62 msgid "By submitting my email address, I consent to being contacted via email at the address provided." msgstr "" @@ -150,12 +156,6 @@ msgstr "" msgid "Thank you for your question!" msgstr "" -#: src/ui/templates/results/alternativeverticals.hbs:11 -msgid "The following search category yielded results for \"[[query]]\":" -msgid_plural "The following search categories yielded results for \"[[query]]\":" -msgstr[0] "" -msgstr[1] "" - #: src/ui/components/results/directanswercomponent.js:23 msgid "This answered my question" msgstr "" diff --git a/src/ui/templates/results/alternativeverticals.hbs b/src/ui/templates/results/alternativeverticals.hbs index 026a83081..d1a4d0303 100644 --- a/src/ui/templates/results/alternativeverticals.hbs +++ b/src/ui/templates/results/alternativeverticals.hbs @@ -8,7 +8,7 @@ {{#if verticalSuggestions}}
- {{translate phrase='The following search category yielded results for "[[query]]":' pluralForm='The following search categories yielded results for "[[query]]":' count=verticalSuggestions.length query=query }} + {{translate phrase='bobob The following search category yielded results for "[[query]]":' pluralForm='The following search categories yielded results for "[[query]]":' count=verticalSuggestions.length query=query }}
    {{#each verticalSuggestions}} From 95e4a5482db683256fc6a899fb1d81d7f8c8e217 Mon Sep 17 00:00:00 2001 From: Oliver Shi Date: Fri, 28 Jan 2022 10:23:48 -0500 Subject: [PATCH 06/15] dont ignore support --- .github/workflows/build_and_deploy.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build_and_deploy.yml b/.github/workflows/build_and_deploy.yml index 4fe1243ba..20b6627a1 100644 --- a/.github/workflows/build_and_deploy.yml +++ b/.github/workflows/build_and_deploy.yml @@ -5,7 +5,7 @@ on: branches-ignore: - develop - master - - support/** + # - support/** - hotfix/** - feature/**-i18n - release/** From 42d01fe5cfad5dfc3a57dcd029413713774429ea Mon Sep 17 00:00:00 2001 From: Oliver Shi Date: Fri, 28 Jan 2022 10:26:31 -0500 Subject: [PATCH 07/15] add gettext --- .github/workflows/miscellaneous_tests.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/miscellaneous_tests.yml b/.github/workflows/miscellaneous_tests.yml index 9f01bd9c9..bd321c8a6 100644 --- a/.github/workflows/miscellaneous_tests.yml +++ b/.github/workflows/miscellaneous_tests.yml @@ -15,4 +15,5 @@ jobs: node-version: 14 cache: 'npm' - run: npm ci + - run: sudo apt-get install -qq gettext - run: ./.github/run_translation_verification.sh \ No newline at end of file From df0bb58da6367311a64e10cd7f594b9c6f474188 Mon Sep 17 00:00:00 2001 From: Oliver Shi Date: Fri, 28 Jan 2022 10:30:52 -0500 Subject: [PATCH 08/15] Revert "test when translations missing" This reverts commit 117ab3688d27d7ee6168781f5442376c29f9238e. --- conf/i18n/translations/messages.pot | 12 ++++++------ src/ui/templates/results/alternativeverticals.hbs | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/conf/i18n/translations/messages.pot b/conf/i18n/translations/messages.pot index 184de8edf..2124a280d 100644 --- a/conf/i18n/translations/messages.pot +++ b/conf/i18n/translations/messages.pot @@ -42,12 +42,6 @@ msgstr "" msgid "Alternatively, you can view results across all search categories." msgstr "" -#: src/ui/templates/results/alternativeverticals.hbs:11 -msgid "bobob The following search category yielded results for \"[[query]]\":" -msgid_plural "The following search categories yielded results for \"[[query]]\":" -msgstr[0] "" -msgstr[1] "" - #: src/ui/components/questions/questionsubmissioncomponent.js:62 msgid "By submitting my email address, I consent to being contacted via email at the address provided." msgstr "" @@ -156,6 +150,12 @@ msgstr "" msgid "Thank you for your question!" msgstr "" +#: src/ui/templates/results/alternativeverticals.hbs:11 +msgid "The following search category yielded results for \"[[query]]\":" +msgid_plural "The following search categories yielded results for \"[[query]]\":" +msgstr[0] "" +msgstr[1] "" + #: src/ui/components/results/directanswercomponent.js:23 msgid "This answered my question" msgstr "" diff --git a/src/ui/templates/results/alternativeverticals.hbs b/src/ui/templates/results/alternativeverticals.hbs index d1a4d0303..026a83081 100644 --- a/src/ui/templates/results/alternativeverticals.hbs +++ b/src/ui/templates/results/alternativeverticals.hbs @@ -8,7 +8,7 @@ {{#if verticalSuggestions}}
    - {{translate phrase='bobob The following search category yielded results for "[[query]]":' pluralForm='The following search categories yielded results for "[[query]]":' count=verticalSuggestions.length query=query }} + {{translate phrase='The following search category yielded results for "[[query]]":' pluralForm='The following search categories yielded results for "[[query]]":' count=verticalSuggestions.length query=query }}
      {{#each verticalSuggestions}} From b456a8a51d0f27188596421ac7273f9bc581a74d Mon Sep 17 00:00:00 2001 From: Oliver Shi Date: Fri, 28 Jan 2022 10:31:13 -0500 Subject: [PATCH 09/15] delete translations --- conf/i18n/translations/ar.po | 10 ---------- conf/i18n/translations/es.po | 3 --- conf/i18n/translations/fr.po | 4 ---- 3 files changed, 17 deletions(-) diff --git a/conf/i18n/translations/ar.po b/conf/i18n/translations/ar.po index a3daef0a2..3394057d5 100755 --- a/conf/i18n/translations/ar.po +++ b/conf/i18n/translations/ar.po @@ -162,16 +162,6 @@ msgstr "شكرًا على ملاحظاتك!" msgid "Thank you for your question!" msgstr "شكرا لك على سؤالك!" -#: src/ui/templates/results/alternativeverticals.hbs:11 -msgid "The following search category yielded results for \"[[query]]\":" -msgid_plural "The following search categories yielded results for \"[[query]]\":" -msgstr[0] "أسفرت فئات البحث التالية عن نتائج لعدد "[[query]]":" -msgstr[1] "أسفرت فئة البحث التالية عن نتائج لعدد "[[query]]":" -msgstr[2] "أسفرت فئات البحث التالية عن نتائج لعدد "[[query]]":" -msgstr[3] "أسفرت فئات البحث التالية عن نتائج لعدد "[[query]]":" -msgstr[4] "أسفرت فئات البحث التالية عن نتائج لعدد "[[query]]":" -msgstr[5] "أسفرت فئات البحث التالية عن نتائج لعدد "[[query]]":" - #: src/ui/components/results/directanswercomponent.js:23 msgid "This answered my question" msgstr "هذا أجاب عن سؤالي" diff --git a/conf/i18n/translations/es.po b/conf/i18n/translations/es.po index face91d2e..d4dabc95c 100755 --- a/conf/i18n/translations/es.po +++ b/conf/i18n/translations/es.po @@ -216,9 +216,6 @@ msgstr "Sugerencias:" msgid "Thank you for your feedback!" msgstr "Gracias por su comentario" -#: src/ui/components/questions/questionsubmissioncomponent.js:127 -msgid "Thank you for your question!" -msgstr "Gracias por su pregunta." #: src/ui/templates/results/alternativeverticals.hbs:11 msgid "The following search category yielded results for \"[[query]]\":" diff --git a/conf/i18n/translations/fr.po b/conf/i18n/translations/fr.po index dab1e8855..a40b2d3cb 100755 --- a/conf/i18n/translations/fr.po +++ b/conf/i18n/translations/fr.po @@ -201,10 +201,6 @@ msgstr "Voici msgid "Speech Recognition is not available." msgstr "La reconnaissance vocale n'est pas disponible." -#: src/ui/templates/results/noresults.hbs:24 -msgid "Suggestions:" -msgstr "Suggestions:" - #: src/ui/components/results/directanswercomponent.js:29 msgid "Thank you for your feedback!" msgstr "Merci pour vos retours !" From 62c657a0d396fbdb87be333c2adeb907feba6d27 Mon Sep 17 00:00:00 2001 From: Oliver Shi Date: Fri, 28 Jan 2022 10:50:06 -0500 Subject: [PATCH 10/15] remove if --- .github/run_translation_verification.sh | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/.github/run_translation_verification.sh b/.github/run_translation_verification.sh index 4c9b69d3c..81a31ded5 100755 --- a/.github/run_translation_verification.sh +++ b/.github/run_translation_verification.sh @@ -16,14 +16,7 @@ fi # Verify that translations are present for all languages cd conf/i18n/translations -if [[ $GITHUB_REF_NAME == release/* - || $GITHUB_REF_NAME == hotfix/* - || $GITHUB_REF_NAME == master - || $GITHUB_REF_NAME == support/* ]] -then - for po_file in *.po - do msgcmp $po_file messages.pot - done -else - echo "Skipping the verification that all translations are present" -fi \ No newline at end of file + +for po_file in *.po + do msgcmp $po_file messages.pot +done \ No newline at end of file From 427f0d2df614ac1f152295387696c926bbb11eee Mon Sep 17 00:00:00 2001 From: Oliver Shi Date: Fri, 28 Jan 2022 10:57:14 -0500 Subject: [PATCH 11/15] comment out other flows so it doesnt short circuit --- .github/workflows/build_and_deploy.yml | 66 +++++++++++++------------- 1 file changed, 33 insertions(+), 33 deletions(-) diff --git a/.github/workflows/build_and_deploy.yml b/.github/workflows/build_and_deploy.yml index 20b6627a1..a171e3687 100644 --- a/.github/workflows/build_and_deploy.yml +++ b/.github/workflows/build_and_deploy.yml @@ -11,46 +11,46 @@ on: - release/** jobs: - call_build: - uses: ./.github/workflows/build.yml + # call_build: + # uses: ./.github/workflows/build.yml - call_unit_test: - uses: ./.github/workflows/unit_test.yml - needs: call_build + # call_unit_test: + # uses: ./.github/workflows/unit_test.yml + # needs: call_build call_misc_tests: uses: ./.github/workflows/miscellaneous_tests.yml - call_acceptance: - uses: ./.github/workflows/acceptance.yml - needs: call_build - secrets: - BROWSERSTACK_USERNAME: ${{ secrets.BROWSERSTACK_USERNAME }} - BROWSERSTACK_ACCESS_KEY: ${{ secrets.BROWSERSTACK_ACCESS_KEY }} + # call_acceptance: + # uses: ./.github/workflows/acceptance.yml + # needs: call_build + # secrets: + # BROWSERSTACK_USERNAME: ${{ secrets.BROWSERSTACK_USERNAME }} + # BROWSERSTACK_ACCESS_KEY: ${{ secrets.BROWSERSTACK_ACCESS_KEY }} - format_branch_name: - runs-on: ubuntu-latest - outputs: - formatted_branch: ${{ steps.vars.outputs.formatted_branch }} - steps: - - name: Format branch name # replace '/' with '-' - id: vars - run: | - FORMATTED_BRANCH="$(echo ${GITHUB_REF_NAME} | sed "s/\//-/g")" - echo $FORMATTED_BRANCH - echo ::set-output name=formatted_branch::${FORMATTED_BRANCH} + # format_branch_name: + # runs-on: ubuntu-latest + # outputs: + # formatted_branch: ${{ steps.vars.outputs.formatted_branch }} + # steps: + # - name: Format branch name # replace '/' with '-' + # id: vars + # run: | + # FORMATTED_BRANCH="$(echo ${GITHUB_REF_NAME} | sed "s/\//-/g")" + # echo $FORMATTED_BRANCH + # echo ::set-output name=formatted_branch::${FORMATTED_BRANCH} - call_deploy: - needs: - - call_unit_test - - format_branch_name - - call_acceptance - uses: ./.github/workflows/deploy.yml - with: - directory: dev/${{ needs.format_branch_name.outputs.formatted_branch }} - secrets: - AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} - AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} + # call_deploy: + # needs: + # - call_unit_test + # - format_branch_name + # - call_acceptance + # uses: ./.github/workflows/deploy.yml + # with: + # directory: dev/${{ needs.format_branch_name.outputs.formatted_branch }} + # secrets: + # AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} + # AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} concurrency: group: ci-build-and-deploy-${{ github.ref }}-1 From 59cabf1fc91d6fd570b3874be79796bf913e2c8b Mon Sep 17 00:00:00 2001 From: Oliver Shi Date: Fri, 28 Jan 2022 10:59:08 -0500 Subject: [PATCH 12/15] delete chiense translation --- conf/i18n/translations/zh-Hant.po | 5 ----- 1 file changed, 5 deletions(-) diff --git a/conf/i18n/translations/zh-Hant.po b/conf/i18n/translations/zh-Hant.po index b9b254bf6..513ed7868 100755 --- a/conf/i18n/translations/zh-Hant.po +++ b/conf/i18n/translations/zh-Hant.po @@ -2,11 +2,6 @@ msgid "" msgstr "" "Content-Type: text/plain; charset=UTF-8\n" -#: src/ui/templates/results/alternativeverticals.hbs:28 -msgid "([[resultsCount]] result)" -msgid_plural "([[resultsCount]] results)" -msgstr[0] "([[resultsCount]] 個結果)" - #: src/ui/templates/search/autocomplete.hbs:6 msgid "[[resultsCount]] [[label]] autocomplete option found." msgid_plural "[[resultsCount]] [[label]] autocomplete options found." From 371f5666af3d5afbd0eca5c20adf66348df4bda0 Mon Sep 17 00:00:00 2001 From: Oliver Shi Date: Fri, 28 Jan 2022 11:01:06 -0500 Subject: [PATCH 13/15] add back chinese translation --- .github/workflows/percy_snapshots.yml | 12 ++++++------ conf/i18n/translations/zh-Hant.po | 5 +++++ 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/.github/workflows/percy_snapshots.yml b/.github/workflows/percy_snapshots.yml index ea2d7dd41..5de552b98 100644 --- a/.github/workflows/percy_snapshots.yml +++ b/.github/workflows/percy_snapshots.yml @@ -20,9 +20,9 @@ jobs: uses: actions/setup-node@v2 with: node-version: ${{ matrix.node-version }} - - run: npm ci - - run: npm run build - - name: Percy Snapshots - run: npx percy exec -- node tests/acceptance/percy/snapshots.js - env: - PERCY_TOKEN: ${{ secrets.PERCY_TOKEN }} \ No newline at end of file + # - run: npm ci + # - run: npm run build + # - name: Percy Snapshots + # run: npx percy exec -- node tests/acceptance/percy/snapshots.js + # env: + # PERCY_TOKEN: ${{ secrets.PERCY_TOKEN }} \ No newline at end of file diff --git a/conf/i18n/translations/zh-Hant.po b/conf/i18n/translations/zh-Hant.po index 513ed7868..b9b254bf6 100755 --- a/conf/i18n/translations/zh-Hant.po +++ b/conf/i18n/translations/zh-Hant.po @@ -2,6 +2,11 @@ msgid "" msgstr "" "Content-Type: text/plain; charset=UTF-8\n" +#: src/ui/templates/results/alternativeverticals.hbs:28 +msgid "([[resultsCount]] result)" +msgid_plural "([[resultsCount]] results)" +msgstr[0] "([[resultsCount]] 個結果)" + #: src/ui/templates/search/autocomplete.hbs:6 msgid "[[resultsCount]] [[label]] autocomplete option found." msgid_plural "[[resultsCount]] [[label]] autocomplete options found." From 9b45071637fa7beb10dedb270c17bcd1b62cc865 Mon Sep 17 00:00:00 2001 From: Oliver Shi Date: Fri, 28 Jan 2022 11:05:37 -0500 Subject: [PATCH 14/15] add exit code fix --- .github/run_translation_verification.sh | 18 +++++++++++++++--- conf/i18n/translations/test.sh | 8 ++++++++ 2 files changed, 23 insertions(+), 3 deletions(-) create mode 100755 conf/i18n/translations/test.sh diff --git a/.github/run_translation_verification.sh b/.github/run_translation_verification.sh index 81a31ded5..00f8024ef 100755 --- a/.github/run_translation_verification.sh +++ b/.github/run_translation_verification.sh @@ -17,6 +17,18 @@ fi # Verify that translations are present for all languages cd conf/i18n/translations -for po_file in *.po - do msgcmp $po_file messages.pot -done \ No newline at end of file +exit_code=0 +if [[ $GITHUB_REF_NAME == release/* + || $GITHUB_REF_NAME == hotfix/* + || $GITHUB_REF_NAME == master + || $GITHUB_REF_NAME == support/* ]] +then + for po_file in *.po + do msgcmp $po_file messages.pot + exit_code=$(( exit_code + $? )) + done +else + echo "Skipping the verification that all translations are present" +fi + +exit $exit_code \ No newline at end of file diff --git a/conf/i18n/translations/test.sh b/conf/i18n/translations/test.sh new file mode 100755 index 000000000..8ee6e5406 --- /dev/null +++ b/conf/i18n/translations/test.sh @@ -0,0 +1,8 @@ +exit_code=0 + +for po_file in *.po + do msgcmp $po_file messages.pot + exit_code=$(( exit_code + $? )) +done + +exit $exit_code From 7460344202a4d8db8f15ad7f2f3afede83fd0b9c Mon Sep 17 00:00:00 2001 From: Oliver Shi Date: Fri, 28 Jan 2022 11:06:54 -0500 Subject: [PATCH 15/15] proper formatting --- .github/run_translation_verification.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/run_translation_verification.sh b/.github/run_translation_verification.sh index 00f8024ef..6b0ff4d78 100755 --- a/.github/run_translation_verification.sh +++ b/.github/run_translation_verification.sh @@ -24,7 +24,8 @@ if [[ $GITHUB_REF_NAME == release/* || $GITHUB_REF_NAME == support/* ]] then for po_file in *.po - do msgcmp $po_file messages.pot + do + msgcmp $po_file messages.pot exit_code=$(( exit_code + $? )) done else