From 5d4a9677bab299c903182aa42e92f1e08bd0b7ba Mon Sep 17 00:00:00 2001
From: cea2aj <42848445+cea2aj@users.noreply.github.com>
Date: Mon, 29 Nov 2021 12:07:11 -0500
Subject: [PATCH] Fix useragent acceptance test (#1623)

Fix the failing useragent acceptance tests

The useragent acceptance tests have been failing due to the error: `undefined is not an object (evaluating 'za.objectHasOwnProperty.call(s,"writable")')`, and the callstack shows that testcafe code, not our code, is causing the issue. The error message suggests enabling "skipJsErrors` so that the test doesn't fail. The error is only thrown when ran through testcafe, which further suggests that the issue is on testcafe's side. Therefore, by setting this option we can get the test passing again.

This means that JS errors on the page won't cause the test to fail, however I think that's okay for this test since we have other acceptance tests which would fail if there were JS errors on the page.

J=none
TEST=none

Confirm that the tests now pass.
---
 .github/testcafe.json | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/.github/testcafe.json b/.github/testcafe.json
index 82a7b82c1..4ce49be6e 100644
--- a/.github/testcafe.json
+++ b/.github/testcafe.json
@@ -1,5 +1,6 @@
 {
   "src": ["tests/acceptance/acceptancesuites/*.js", "!tests/acceptance/acceptancesuites/searchbaronlysuite.js"],
   "appCommand": "npx serve -l tcp://0.0.0.0:9999",
-  "appInitDelay": 4000
+  "appInitDelay": 4000,
+  "skipJsErrors": true
 }
\ No newline at end of file