-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: correct implementation of accesssible text for vertical result c…
…ounts The current implementation of verticalresultcount.hbs unnecessarily uses an aria-label and aria-hidden property to handle text that is already accessible for a non-interactive element. J=TECHOPS-9030
- Loading branch information
1 parent
ad4a9ba
commit 5e21825
Showing
2 changed files
with
7 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,16 @@ | ||
{{#unless isHidden}} | ||
<div class="yxt-VerticalResultsCount" | ||
aria-label="{{translate phrase='[[start]] through [[end]] of [[resultsCount]]' start=pageStart end=pageEnd resultsCount=total }}"> | ||
<div aria-hidden="true"> | ||
<div class="yxt-VerticalResultsCount"> | ||
{{translate | ||
phrase= | ||
'<span class="yxt-VerticalResultsCount-start">[[start]]</span> | ||
<span class="yxt-VerticalResultsCount-dash">-</span> | ||
<span class="yxt-VerticalResultsCount-end">[[end]]</span> | ||
<span class="yxt-VerticalResultsCount-of">of</span> | ||
<span class="yxt-VerticalResultsCount-total">[[resultsCount]]</span>' | ||
'<span class="yxt-VerticalResultsCount-start">[[start]]</span> | ||
<span class="yxt-VerticalResultsCount-dash">-</span> | ||
<span class="yxt-VerticalResultsCount-end">[[end]]</span> | ||
<span class="yxt-VerticalResultsCount-of">of</span> | ||
<span class="yxt-VerticalResultsCount-total">[[resultsCount]]</span>' | ||
context='Example: 1-10 of 50' | ||
start=pageStart | ||
end=pageEnd | ||
resultsCount=total | ||
}} | ||
</div> | ||
</div> | ||
{{/unless}} |