From 67b32df6db93d929fc868c28ca1c815d5d10f618 Mon Sep 17 00:00:00 2001
From: Nidhi Manu <nmanu@yext.com>
Date: Tue, 13 Feb 2024 08:55:42 -0500
Subject: [PATCH 1/2] Revert "Change icons from divs to spans (#1857)"

This reverts commit 2d3c39ecc8bafe53584fbc46baf7a5c4e0d15f89 because it causes some visual regressions in the HH theme. The HH Theme has styling that targets spans directly and changing the icon elements from divs to spans caused the icons to be inadverdently targeted by that styling.
---
 src/ui/sass/modules/_SearchBar.scss        |  5 -----
 src/ui/templates/icons/builtInIcon.hbs     |  4 ++--
 src/ui/templates/icons/icon.hbs            |  4 ++--
 src/ui/templates/icons/iconPartial.hbs     |  4 ++--
 src/ui/templates/icons/searchBarIcon.hbs   | 24 +++++++++++-----------
 src/ui/templates/icons/voiceSearchIcon.hbs |  2 +-
 6 files changed, 19 insertions(+), 24 deletions(-)

diff --git a/src/ui/sass/modules/_SearchBar.scss b/src/ui/sass/modules/_SearchBar.scss
index 650d76045..d3cf8879f 100644
--- a/src/ui/sass/modules/_SearchBar.scss
+++ b/src/ui/sass/modules/_SearchBar.scss
@@ -280,7 +280,6 @@ $searchbar-button-text-color-active: var(--yxt-searchbar-button-text-color-base)
 
   &-buttonImage .Icon svg, .Icon-image
   {
-    display: block;
     width: 2em;
     height: 2em;
   }
@@ -288,10 +287,6 @@ $searchbar-button-text-color-active: var(--yxt-searchbar-button-text-color-base)
   &-instructions {
     display: none;
   }
-
-  &-CustomLoadingImage {
-    display: block;
-  }
 }
 
 // If custom icons are supplied, the SVGs simply alternate opacity
diff --git a/src/ui/templates/icons/builtInIcon.hbs b/src/ui/templates/icons/builtInIcon.hbs
index 00b0c3b82..0355d648e 100644
--- a/src/ui/templates/icons/builtInIcon.hbs
+++ b/src/ui/templates/icons/builtInIcon.hbs
@@ -1,3 +1,3 @@
-<span class="Icon Icon--{{iconName}} {{classNames}}" aria-hidden="true">
+<div class="Icon Icon--{{iconName}} {{classNames}}" aria-hidden="true">
   {{icon iconName complexContentsParams}}
-</span>
\ No newline at end of file
+</div>
\ No newline at end of file
diff --git a/src/ui/templates/icons/icon.hbs b/src/ui/templates/icons/icon.hbs
index c272170c1..422af5e7f 100644
--- a/src/ui/templates/icons/icon.hbs
+++ b/src/ui/templates/icons/icon.hbs
@@ -1,7 +1,7 @@
-<span class="Icon Icon--{{name}} {{classNames}}" aria-hidden="true">
+<div class="Icon Icon--{{name}} {{classNames}}" aria-hidden="true">
   {{#if iconUrl}}
     <img src="{{iconUrl}}" alt="" class="Icon-image">
   {{else}}
     {{icon iconName complexContentsParams}}
   {{/if}}
-</span>
+</div>
diff --git a/src/ui/templates/icons/iconPartial.hbs b/src/ui/templates/icons/iconPartial.hbs
index 2e6020fdc..e9538d044 100644
--- a/src/ui/templates/icons/iconPartial.hbs
+++ b/src/ui/templates/icons/iconPartial.hbs
@@ -1,7 +1,7 @@
-<span class="Icon Icon--{{#if iconName}}{{iconName}}{{else}}custom{{/if}} {{classNames}}" aria-hidden="true">
+<div class="Icon Icon--{{#if iconName}}{{iconName}}{{else}}custom{{/if}} {{classNames}}" aria-hidden="true">
   {{#if iconUrl}}
     <img src="{{iconUrl}}" alt="" class="Icon-image">
   {{else}}
     {{icon iconName complexContentsParams}}
   {{/if}}
-</span>
\ No newline at end of file
+</div>
\ No newline at end of file
diff --git a/src/ui/templates/icons/searchBarIcon.hbs b/src/ui/templates/icons/searchBarIcon.hbs
index 617dcca42..c15c187e5 100644
--- a/src/ui/templates/icons/searchBarIcon.hbs
+++ b/src/ui/templates/icons/searchBarIcon.hbs
@@ -1,41 +1,41 @@
 {{#if showLoadingIndicator}}
   {{#if customLoadingIconUrl}}
-    <span class="yxt-SearchBar-CustomLoadingImage js-yxt-SearchBar-LoadingIndicator js-yxt-SearchBar-Icon yxt-SearchBar-Icon--inactive">
+    <div class="yxt-SearchBar-CustomLoadingImage js-yxt-SearchBar-LoadingIndicator js-yxt-SearchBar-Icon yxt-SearchBar-Icon--inactive">
       {{> icons/iconPartial iconUrl=customLoadingIconUrl}}
-    </span>
+    </div>
   {{else}}
-    <span class="yxt-SearchBar-AnimatedIcon js-yxt-SearchBar-LoadingIndicator yxt-SearchBar-LoadingIndicator js-yxt-SearchBar-Icon 
+    <div class="yxt-SearchBar-AnimatedIcon js-yxt-SearchBar-LoadingIndicator yxt-SearchBar-LoadingIndicator js-yxt-SearchBar-Icon 
       yxt-SearchBar-Icon--inactive Icon--lg">
       <svg class= "yxt-SearchBar-LoadingIndicator-AnimatedIcon" viewBox="0 0 72 72">
         <circle class="yxt-SearchBar-LoadingIndicator-Circle" cx="36" cy="36" r="33" stroke="black" stroke-width="3" fill="none"/>
       </svg>
-    </span>
+    </div>
   {{/if}}
 {{/if}}
 
 {{#if submitIcon}}
-  <span class="yxt-SearchBar-buttonImage js-yxt-SearchBar-buttonImage js-yxt-SearchBar-Icon">
+  <div class="yxt-SearchBar-buttonImage js-yxt-SearchBar-buttonImage js-yxt-SearchBar-Icon">
     {{> icons/builtInIcon iconName=submitIcon}}
-  </span>
+  </div>
 {{else if _config.customIconUrl}}
-  <span class="yxt-SearchBar-buttonImage js-yxt-SearchBar-buttonImage js-yxt-SearchBar-Icon">
+  <div class="yxt-SearchBar-buttonImage js-yxt-SearchBar-buttonImage js-yxt-SearchBar-Icon">
     {{> icons/iconPartial iconUrl=_config.customIconUrl}}
-  </span>
+  </div>
 {{else}}
-  <span class="yxt-SearchBar-AnimatedIcon js-yxt-AnimatedForward js-yxt-SearchBar-Icon
+  <div class="yxt-SearchBar-AnimatedIcon js-yxt-AnimatedForward js-yxt-SearchBar-Icon
     {{#unless autoFocus}} yxt-SearchBar-Icon--inactive{{/unless}}">
     {{> icons/builtInIcon
       iconName='yext_animated_forward'
       classNames='yxt-SearchBar-MagnifyingGlass--static Icon--lg'
       complexContentsParams=forwardIconOpts.complexContentsParams
     }}
-  </span>
-  <span class="yxt-SearchBar-AnimatedIcon js-yxt-AnimatedReverse js-yxt-SearchBar-Icon
+  </div>
+  <div class="yxt-SearchBar-AnimatedIcon js-yxt-AnimatedReverse js-yxt-SearchBar-Icon
     {{#if autoFocus}} yxt-SearchBar-Icon--inactive{{/if}}">
     {{> icons/builtInIcon
       iconName='yext_animated_reverse'
       classNames='yxt-SearchBar-Yext--static Icon--lg'
       complexContentsParams=forwardIconOpts.complexContentsParams
     }}
-  </span>
+  </div>
 {{/if}}
diff --git a/src/ui/templates/icons/voiceSearchIcon.hbs b/src/ui/templates/icons/voiceSearchIcon.hbs
index 132788adf..8160ef592 100644
--- a/src/ui/templates/icons/voiceSearchIcon.hbs
+++ b/src/ui/templates/icons/voiceSearchIcon.hbs
@@ -14,4 +14,4 @@
     {{/if}}
   </div>
   <span class="yxt-SearchBar-voiceSearchText sr-only"></span>
-</div>
+</div>
\ No newline at end of file

From f0f20613205a96272019d9dfe157a858b86187fa Mon Sep 17 00:00:00 2001
From: "github-actions[bot]"
 <41898282+github-actions[bot]@users.noreply.github.com>
Date: Tue, 13 Feb 2024 08:57:54 -0500
Subject: [PATCH 2/2]  Update Package Version to v1.16.7 (#1863)

*An automated PR which updates the version number in package.json and package-lock.json files*
---
 package-lock.json | 4 ++--
 package.json      | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index c9f6f6601..2f2a33185 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1,12 +1,12 @@
 {
   "name": "@yext/answers-search-ui",
-  "version": "1.16.6",
+  "version": "1.16.7",
   "lockfileVersion": 2,
   "requires": true,
   "packages": {
     "": {
       "name": "@yext/answers-search-ui",
-      "version": "1.16.6",
+      "version": "1.16.7",
       "license": "BSD-3-Clause",
       "dependencies": {
         "@mapbox/mapbox-gl-language": "^0.10.1",
diff --git a/package.json b/package.json
index 0e9dd90c3..7637d2d09 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@yext/answers-search-ui",
-  "version": "1.16.6",
+  "version": "1.16.7",
   "description": "Javascript Search Programming Interface",
   "main": "dist/answers-umd.js",
   "repository": {