Skip to content

chore(f/l): Integrate Pyupgrade to AuthX Environment - #216

Merged
yezz123 merged 1 commit into
mainfrom
pyupgrade
Mar 15, 2022
Merged

yezz123 merged 1 commit into
mainfrom
pyupgrade

Conversation

@yezz123

@yezz123 yezz123 commented Mar 15, 2022

Copy link
Copy Markdown
Owner

Integrating this tool to AuthX environment https://github.com/asottile/pyupgrade

@yezz123 yezz123 added the dependencies Pull requests that update a dependency file label Mar 15, 2022
@yezz123 yezz123 self-assigned this Mar 15, 2022
@pull-request-quantifier-deprecated

Copy link
Copy Markdown

This PR has 9 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +6 -3
Percentile : 3.6%

Total files changed: 2

Change summary by file extension:
.yaml : +5 -0
.toml : +1 -3

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@codecov

codecov Bot commented Mar 15, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #216 (9cd03ec) into main (5c34536) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #216   +/-   ##
=======================================
  Coverage   93.83%   93.83%           
=======================================
  Files          41       41           
  Lines        1444     1444           
=======================================
  Hits         1355     1355           
  Misses         89       89           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c34536...9cd03ec. Read the comment docs.

@yezz123
yezz123 merged commit 6fa1ef8 into main Mar 15, 2022
@yezz123
yezz123 deleted the pyupgrade branch March 15, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file Extra Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant