Skip to content

➕ Support Python 3.11 - #355

Merged
yezz123 merged 4 commits into
mainfrom
python311
Feb 6, 2023
Merged

➕ Support Python 3.11#355
yezz123 merged 4 commits into
mainfrom
python311

Conversation

@yezz123

@yezz123 yezz123 commented Feb 6, 2023

Copy link
Copy Markdown
Owner

No description provided.

@yezz123 yezz123 added enhancement New feature or request python Pull requests that update Python code github_actions Pull requests that update GitHub Actions code labels Feb 6, 2023
@yezz123 yezz123 self-assigned this Feb 6, 2023
@codecov

codecov Bot commented Feb 6, 2023

Copy link
Copy Markdown

Codecov Report

Base: 91.78% // Head: 91.78% // No change to project coverage 👍

Coverage data is based on head (7f9397a) compared to base (01f9699).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 7f9397a differs from pull request most recent head c98b64f. Consider uploading reports for the commit c98b64f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #355   +/-   ##
=======================================
  Coverage   91.78%   91.78%           
=======================================
  Files          56       56           
  Lines        1985     1985           
=======================================
  Hits         1822     1822           
  Misses        163      163           
Impacted Files Coverage Δ
tests/cache/test_method_cache.py 92.50% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sourcery-ai

sourcery-ai Bot commented Feb 6, 2023

Copy link
Copy Markdown
Contributor

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 0.31 ⭐ 0.31 ⭐ 0.00
Method Length 41.16 ⭐ 41.03 ⭐ -0.13 👍
Working memory 7.72 🙂 7.72 🙂 0.00
Quality 82.78% 82.78% 0.00%
Other metrics Before After Change
Lines 277 277 0
Changed files Quality Before Quality After Quality Change
authx/__init__.py 74.00% 🙂 74.00% 🙂 0.00%
authx/main.py 72.89% 🙂 72.89% 🙂 0.00%
authx/cache/redis.py 94.74% ⭐ 94.74% ⭐ 0.00%
tests/test_version.py 99.83% ⭐ 99.83% ⭐ 0.00%
tests/cache/test_method_cache.py 91.69% ⭐ 91.69% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
authx/main.py Authentication.__init__ 0 ⭐ 168 😞 21 ⛔ 48.26% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@yezz123
yezz123 marked this pull request as ready for review February 6, 2023 18:02
@yezz123
yezz123 merged commit b653fba into main Feb 6, 2023
@yezz123
yezz123 deleted the python311 branch February 6, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request github_actions Pull requests that update GitHub Actions code python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant