Use relative path for zookeeper.node symlink #91

Merged
merged 3 commits into from Sep 30, 2013

Conversation

Projects
None yet
2 participants
@devoncrouse

Addresses #90

If this is acceptable, please npm publish. Thanks!

Change-Id: I1d062db4a58a076eaaf667785968df9342d834a3

Devon Crouse added some commits Sep 20, 2013

Devon Crouse
Use relative path for zookeeper.node symlink
Change-Id: I1d062db4a58a076eaaf667785968df9342d834a3
Devon Crouse
Minor cleanup in symlink script
Change-Id: I4ee40ed2532fdbcdf273769bfd187c10dc520b83
@kuebk

This comment has been minimized.

Show comment
Hide comment
@kuebk

kuebk Sep 20, 2013

Collaborator

Version should be 3.4.5-2, please fix it and I'll merge.

Collaborator

kuebk commented Sep 20, 2013

Version should be 3.4.5-2, please fix it and I'll merge.

@devoncrouse

This comment has been minimized.

Show comment
Hide comment
@devoncrouse

devoncrouse Sep 20, 2013

I can update, but out of curiosity: why update the pre-release for the same patch instead of the patch itself?

http://semver.org/

I can update, but out of curiosity: why update the pre-release for the same patch instead of the patch itself?

http://semver.org/

@kuebk

This comment has been minimized.

Show comment
Hide comment
@kuebk

kuebk Sep 20, 2013

Collaborator

3.4.5 stands for the ZK version used.

Collaborator

kuebk commented Sep 20, 2013

3.4.5 stands for the ZK version used.

Devon Crouse
Updated version according to package convention
Change-Id: I0184c5e27fcff76757ca9ee2f6f160974a15a665
@devoncrouse

This comment has been minimized.

Show comment
Hide comment
@devoncrouse

devoncrouse Sep 21, 2013

Version is fixed; everything look okay for merge?

Version is fixed; everything look okay for merge?

kuebk added a commit that referenced this pull request Sep 30, 2013

Merge pull request #91 from devoncrouse/master
Use relative path for zookeeper.node symlink

@kuebk kuebk merged commit d02b6d7 into yfinkelstein:master Sep 30, 2013

@kuebk

This comment has been minimized.

Show comment
Hide comment
@kuebk

kuebk Sep 30, 2013

Collaborator

Merged, thanks.

Collaborator

kuebk commented Sep 30, 2013

Merged, thanks.

@kuebk

This comment has been minimized.

Show comment
Hide comment
@kuebk

kuebk Sep 30, 2013

Collaborator

Published to NPM.

Collaborator

kuebk commented Sep 30, 2013

Published to NPM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment