Skip to content

Yuri Finkelstein yfinkelstein

  • Joined on Dec 11, 2009
yfinkelstein commented on issue ellzey/libevhtp#113
Yuri Finkelstein

I understand the sockets of the pair are async and in theory send and recv can read/write arbitrary number of bytes and so writing from multiple th…

Yuri Finkelstein
why lock around send and recv in evthr.c?
yfinkelstein commented on issue logcabin/logcabin#49
Yuri Finkelstein

After the latest checkout I no longer have problem #2 with missing files on new servers. With the gcc bug workaround above everything works smooth…

yfinkelstein commented on issue logcabin/logcabin#49
Yuri Finkelstein

I ended up copying the file 0000000000000001 from server1 to other two locations and after that the other servers run normally and the hello world …

yfinkelstein commented on issue logcabin/logcabin#49
Yuri Finkelstein

Finally I found the root cause. What I did is replaced cv.wait_until (..) with cv.wait (..) in case the wait time is time_point::max() which is the…

yfinkelstein commented on issue logcabin/logcabin#49
Yuri Finkelstein

I have further narrowed it to line 111 in ConditionVaribale.h: printf ("before cv.wait_until(%ld)", abs_time); cv.wait_until(lockGuard, abs_time);

yfinkelstein commented on issue logcabin/logcabin#50
Yuri Finkelstein

commenting the line 752 per your suggestion did not alter the behavior - still 100% CPU

yfinkelstein commented on issue logcabin/logcabin#50
Yuri Finkelstein

Yes, all unit tests and mock smoke test have passed without a problem. I did not have any compilation problems at all.

yfinkelstein commented on issue logcabin/logcabin#49
Yuri Finkelstein

yes, you're right. entries.size() start with 1 because you initialize the log with one entry. I would argue that this is not a good coding practice…

yfinkelstein commented on issue logcabin/logcabin#49
Yuri Finkelstein

in particular, loop on line 134: for (uint64_t entryId = consensus.log->getLogStartIndex(); entryId <= consensus.log->getLastLogIndex(); ++entryId…

yfinkelstein commented on issue logcabin/logcabin#49
Yuri Finkelstein

I think here is what's going on. In file RaftLog.cc: uint64_t Log::getLogStartIndex() const { return startId; } uint64_t Log::getLastLogIndex() con…

yfinkelstein commented on issue logcabin/logcabin#50
Yuri Finkelstein

The latest commit I have 6e93ddd I did a pull just before run. Here is the backtrace after hitting Control-C: Thread 5 (Thread 0x7fad0fdd0700 (LWP …

yfinkelstein commented on issue logcabin/logcabin#49
Yuri Finkelstein

I have the latest commit pulled today before running the test. Here is the back trace: (gdb) thread apply all backtrace Thread 5 (Thread 0x7fad0fdd…

Yuri Finkelstein
leader process hangs after Conrol-C
Yuri Finkelstein
100% cpu in event loop
Yuri Finkelstein
incorrect handling of "repeated bytes"
Yuri Finkelstein

I'm not sure if that's OK from licensing perspective. From: Jakub Lekstan notifications@github.com To: yfinkelstein/node-zookeeper node-zookeeper@n…

Yuri Finkelstein

I support the idea of only supporting 0.8 in the master and keep 0.6 in a branch. From: Jakub Lekstan notifications@github.com To: yfinkelstein/nod…

yfinkelstein commented on pull request yfinkelstein/node-zookeeper#72
Yuri Finkelstein

I think the question about consistency is valid. But it's true that close should return something. I will merge the request for now and hopefully l…

Yuri Finkelstein
Yuri Finkelstein
Returning JS object on close event
1 commit with 1 addition and 1 deletion
yfinkelstein commented on pull request yfinkelstein/node-zookeeper#69
Yuri Finkelstein

Mark has already did the initial work on conversion to libuv. I will take his work and finish whatever is remaining as soon as I get some time.

yfinkelstein commented on pull request yfinkelstein/node-zookeeper#69
Yuri Finkelstein

thanks!

Yuri Finkelstein
Yuri Finkelstein
Node 0.8 polling fix
2 commits with 17 additions and 5 deletions
Yuri Finkelstein
Compilation fails since Node v0.8.3
Yuri Finkelstein

This is fixed in 0.8.4

Yuri Finkelstein
Something went wrong with that request. Please try again.