Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Twitter account of OGP tag #25

Merged
merged 1 commit into from Jan 9, 2019
Merged

Fix Twitter account of OGP tag #25

merged 1 commit into from Jan 9, 2019

Conversation

@Tiryoh
Copy link
Contributor

Tiryoh commented Jan 9, 2019

OGPタグのtwitter:creatortwitter:site@usernameで指定するようなのですが、TwitterアカウントのURLがそのまま指定されていたので修正しました。

下記URLのCard and Content Attributionのセクションにtwitter:creatortwitter:siteについての記述があります。
https://developer.twitter.com/en/docs/tweets/optimize-with-cards/guides/getting-started

@yhira yhira merged commit 0fd0492 into yhira:master Jan 9, 2019
@yhira

This comment has been minimized.

Copy link
Owner

yhira commented Jan 9, 2019

プルリクエストありがとうございます!
確かに、URLが出力されてしまっていましたね^^;
マージさせていただきました。

@Tiryoh Tiryoh deleted the memoteki:fix_ogp_tag branch Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.