Should colon be allowed in path?

[Gjergj]

This says no but there are some places where colons are used in the path
https://en.wikipedia.org/wiki/Template:Welcome
https://identitytoolkit.googleapis.com/v1/accounts:signInWithCustomToken

This library encodes the colon in path.
I think it should be allowed in path.

[Gjergj]

In the case of googleapi if the colon in the path is encoded than google returns 404

[yhirose]

@Gjergj, thanks for the feedback, but I couldn't reproduce it on my machine. I tested with the following code and it worked fine. Did I miss something?

#include <iostream>
#include <httplib.h>
using namespace httplib;
using namespace std;

int main(void) {
  httplib::SSLClient cli("en.wikipedia.org");
  auto res = cli.Get("/wiki/Template:Welcome");
  if (res) {
    cout << res->status << endl;
    cout << res->body << endl;
  }
  return 0;
}

[Gjergj]

Apparently it is just google. Try:

 httplib::SSLClient cli("identitytoolkit.googleapis.com");
 auto res = cli.Post("/v1/accounts:signUp?key=A7J5WTaUK8YA",R"({"email":"xyz@zyx.com","password":"superpassword","returnSecureToken":true})","application/json" );

    if (res) {
        std::cout << res->status << std::endl;
        std::cout << res->body << std::endl;
    }

[yhirose]

@Gjergj, thanks for the report. I don't have time the rest of this week to work on it. But at least, could you do the same test with curl to see what happens? It will be helpful. Thanks!

[Gjergj]

With curl it is ok.

curl 'https://identitytoolkit.googleapis.com/v1/accounts:signInWithCustomToken?key=123456789' -H 'Content-Type: application/json' --data-binary '{"token":"123456789","returnSecureToken":true}'

It will just complain because of wrong token and key but will not give 404.

[yhirose]

@Gjergj, I have actually fixed it. Thanks for your contribution!