support integer ip addresses #7

Merged
merged 3 commits into from Aug 5, 2014

Projects

None yet

2 participants

@alexdean
Contributor

I already store ip addresses in my database as integers. I would like to be able to do geocoding on these ip addresses without the intermediate step of first converting them to strings. This is good both for code simplicity and performance.

Separate issue: I ran rake ensure_maxmind_files prior to running specs. The database files I fetched contained the new country code you see in c47cd21. I included the change in this PR so that the test suite would be 100% passing.

alexdean added some commits Jul 23, 2014
@alexdean alexdean whitespace fixes a0f1113
@alexdean alexdean country code has changed in most recent mmdb file. c47cd21
@alexdean alexdean support integer ip addresses
If client already has ip addresses as integers, there should be no need to
convert to strings so that maxminddb can re-convert back to integers.
5382480
@yhirose yhirose merged commit 0aff4d9 into yhirose:master Aug 5, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@yhirose
Owner
yhirose commented Aug 5, 2014

Dear Alex,

The change looks great. I'll bump up the gem version number to 0.1.2 soon.
Thanks for your contribution!!

Yuji

@alexdean
Contributor
alexdean commented Aug 5, 2014

Great! Thank you, Yuji.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment