Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

Reapply r160148 (reverted in r163570) fixing spurious breakpoints in …

…modern GDB

This reapplies the fix for PR13303 now with more justification. Based on my
execution of the GDB 7.5 test suite this results in:

expected passes: 16101 -> 20890 (+30%)
unexpected failures: 4826 -> 637 (-77%)

There are 23 checks that used to pass and now fail. They are all in
gdb.reverse. Investigating a few looks like they were accidentally passing
due to extra breakpoints being set by this bug. They're generally due to the
difference in end location between gcc and clang, the test suite is trying to
set breakpoints on the closing '}' that clang doesn't associate with any
instructions.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@169304 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information...
commit b36c531653913cdea211a25d45350e8b5bfbd262 1 parent 8181827
authored December 04, 2012
2  lib/CodeGen/AsmPrinter/DwarfDebug.cpp
@@ -1511,7 +1511,7 @@ void DwarfDebug::beginFunction(const MachineFunction *MF) {
1511 1511
                                        MF->getFunction()->getContext());
1512 1512
     recordSourceLine(FnStartDL.getLine(), FnStartDL.getCol(),
1513 1513
                      FnStartDL.getScope(MF->getFunction()->getContext()),
1514  
-                     0);
  1514
+                     DWARF2_FLAG_IS_STMT);
1515 1515
   }
1516 1516
 }
1517 1517
 
28  test/DebugInfo/X86/pr13303.ll
... ...
@@ -0,0 +1,28 @@
  1
+; RUN: llc %s -o %t -filetype=obj -mtriple=x86_64-unknown-linux-gnu
  2
+; RUN: llvm-dwarfdump %t | FileCheck %s
  3
+; PR13303
  4
+
  5
+; Check that the prologue ends with is_stmt here.
  6
+; CHECK: 0x0000000000000000 {{.*}} is_stmt
  7
+
  8
+define i32 @main() nounwind uwtable {
  9
+entry:
  10
+  %retval = alloca i32, align 4
  11
+  store i32 0, i32* %retval
  12
+  ret i32 0, !dbg !10
  13
+}
  14
+
  15
+!llvm.dbg.cu = !{!0}
  16
+
  17
+!0 = metadata !{i32 786449, i32 0, i32 12, metadata !"PR13303.c", metadata !"/home/probinson", metadata !"clang version 3.2 (trunk 160143)", i1 true, i1 false, metadata !"", i32 0, metadata !1, metadata !1, metadata !3, metadata !1} ; [ DW_TAG_compile_unit ] [/home/probinson/PR13303.c] [DW_LANG_C99]
  18
+!1 = metadata !{metadata !2}
  19
+!2 = metadata !{i32 0}
  20
+!3 = metadata !{metadata !4}
  21
+!4 = metadata !{metadata !5}
  22
+!5 = metadata !{i32 786478, i32 0, metadata !6, metadata !"main", metadata !"main", metadata !"", metadata !6, i32 1, metadata !7, i1 false, i1 true, i32 0, i32 0, null, i32 0, i1 false, i32 ()* @main, null, null, metadata !1, i32 1} ; [ DW_TAG_subprogram ] [line 1] [def] [main]
  23
+!6 = metadata !{i32 786473, metadata !"PR13303.c", metadata !"/home/probinson", null} ; [ DW_TAG_file_type ]
  24
+!7 = metadata !{i32 786453, i32 0, metadata !"", i32 0, i32 0, i64 0, i64 0, i64 0, i32 0, null, metadata !8, i32 0, i32 0} ; [ DW_TAG_subroutine_type ] [line 0, size 0, align 0, offset 0] [from ]
  25
+!8 = metadata !{metadata !9}
  26
+!9 = metadata !{i32 786468, null, metadata !"int", null, i32 0, i64 32, i64 32, i64 0, i32 0, i32 5} ; [ DW_TAG_base_type ] [int] [line 0, size 32, align 32, offset 0, enc DW_ATE_signed]
  27
+!10 = metadata !{i32 1, i32 14, metadata !11, null}
  28
+!11 = metadata !{i32 786443, metadata !5, i32 1, i32 12, metadata !6, i32 0} ; [ DW_TAG_lexical_block ] [/home/probinson/PR13303.c]

0 notes on commit b36c531

Please sign in to comment.
Something went wrong with that request. Please try again.