Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap or refactor EmergencyBrake #472

Closed
alcueca opened this issue Jul 26, 2022 · 1 comment
Closed

Wrap or refactor EmergencyBrake #472

alcueca opened this issue Jul 26, 2022 · 1 comment
Assignees

Comments

@alcueca
Copy link
Collaborator

alcueca commented Jul 26, 2022

EmergencyBrake is cumbersome to use and maintain, to the point that it has been mostly neglected since launch.

The EmergencyBrake should be refactored or wrapped, so that the user experience is something like calling isolate(address), instead of remembering with set of arbitrary-looking hashes need to be executed.

I think we can still store a very long calldata string as the plan, indexed by the contract that we understand that we are isolating. We would need to be able to edit the plan, so maybe storing it as an array of calls would work better, not sure.

If we choose to wrap instead, then the wrapper would map one address to a number of plans identified by their hash, and execute them sequentially.

@alcueca
Copy link
Collaborator Author

alcueca commented Jan 6, 2023

Done

@alcueca alcueca closed this as completed Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants