Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about the extension button. #1

Closed
dmitshur opened this issue Apr 1, 2016 · 3 comments

Comments

@dmitshur
Copy link

commented Apr 1, 2016

Hi @yifanwu,

I think Chrome (stable channel) has made some change in one of the recent updates where all extensions will display a button. Previously, right clicking the button and hiding it would actually hide it from view. But now it appears in the menu bar:

image

I am wondering where that text is coming from. The "That's the tool tip" string. I don't see it anywhere in the source, is it coming from Chrome somehow? Or is the source of the published extension (i.e., https://chrome.google.com/webstore/detail/blank-new-tab/beafekehjfhnkpnnjegadfdncaipnljp) slightly different than what's in this repo?

Thanks!

@dmitshur

This comment has been minimized.

Copy link
Author

commented Sep 21, 2019

Or is the source of the published extension (i.e., https://chrome.google.com/webstore/detail/blank-new-tab/beafekehjfhnkpnnjegadfdncaipnljp) slightly different than what's in this repo?

The extension in Chrome Web Store is at version 0.0.2, while the manifest.json file in this repository is at version 0.0.1:

"version": "0.0.1",

So that must mean the source code here is slightly out of date. That would explain the difference I was seeing.

Closing since this question has been answered.

@dmitshur dmitshur closed this Sep 21, 2019
@yifanwu

This comment has been minimized.

Copy link
Owner

commented Oct 3, 2019

Hey @dmitshur sorry I just saw this question now; seems like it's fixed? Otherwise I'm happy to review a PR : )

@dmitshur

This comment has been minimized.

Copy link
Author

commented Oct 3, 2019

No worries! I inferred the answer from public information that I could find. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.