Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds options class.output and class.source for html documents #1335

Merged
merged 7 commits into from Dec 13, 2016

Conversation

Projects
None yet
2 participants
@ijlyttle
Copy link
Contributor

commented Dec 11, 2016

Addresses #1333

This work is just beginning - I am opening the PR now so that @yihui and @AmeliaMN can pull me back towards the right path should I go the wrong way.

  • code
    • adapt render_markdown() in hooks-md.R
      • class.source
      • class.output
      • clean out extraneous comments in hooks.t.output
  • documentation
  • add a name to DESCRIPTION/Contributors

If you prefer to keep all the feedback until the whole PR is "done", I'll send a signal when I think I am there.

FWIW, here's a gist with the Rmd file I've been using to test things.

ijlyttle added some commits Dec 11, 2016

@yihui

This comment has been minimized.

Copy link
Owner

commented Dec 13, 2016

  • Don't worry about the duplicated code. I'll take care of it since it is simple enough.
  • The documentation can be added here (as you have found out): https://github.com/yihui/knitr/blob/master/docs/options/index.md No need to add vignettes or Rd.
  • No need to add tests under tests/. An example in the knitr-examples repo will be great, though, and that can serve as a test.
  • Then add your name to DESCRIPTION and done.
@ijlyttle

This comment has been minimized.

Copy link
Contributor Author

commented Dec 13, 2016

Will do - should not be much longer - thanks!

@ijlyttle ijlyttle referenced this pull request Dec 13, 2016

Merged

Option class #50

@ijlyttle

This comment has been minimized.

Copy link
Contributor Author

commented Dec 13, 2016

Done, methinks (mehopes). Thanks for the navigation through the process, @yihui!

@yihui yihui merged commit 81ce0ae into yihui:master Dec 13, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@yihui yihui added this to the v1.16 milestone Dec 13, 2016

yihui added a commit that referenced this pull request Dec 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.