Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rladies.css #76

Merged
merged 4 commits into from Nov 2, 2017
Merged

add rladies.css #76

merged 4 commits into from Nov 2, 2017

Conversation

@apreshill
Copy link
Contributor

apreshill commented Oct 7, 2017

In response to your blog post!
https://yihui.name/en/2017/10/xaringan-themes/

Copy link
Owner

yihui left a comment

Thanks a lot!

You can remove the duplicated CSS and only keep the differences with default.css. Then you can use a vector for css:

output:
  xaringan::moon_reader:
    css: [default, rladies]

This makes the theme more extensible and easier for me to maintain the base CSS (i.e. default.css).

BTW, could you sign the contributor agreement? http://www.clahub.com/agreements/yihui/xaringan

}
.inverse h1, .inverse h2, .inverse h3 {
color: #FFFFFF;
line-height: 1.0em;

This comment has been minimized.

Copy link
@yihui

yihui Oct 7, 2017

Owner

I recently removed this line c4f63f2 since it does not really make sense.

yihui added a commit that referenced this pull request Oct 7, 2017
…nt styles without copying everything from default.css (#76)
@yihui

This comment has been minimized.

Copy link
Owner

yihui commented Oct 27, 2017

@apreshill I have removed the duplicated CSS, and now you only need to sign the contributor agreement: https://www.clahub.com/agreements/yihui/xaringan

yihui added 2 commits Oct 27, 2017
@yihui
yihui approved these changes Oct 27, 2017
@apreshill

This comment has been minimized.

Copy link
Contributor Author

apreshill commented Oct 31, 2017

Thank you @yihui , too many balls at one time I'm afraid! Sorry for creating extra work for you

@apreshill apreshill closed this Oct 31, 2017
@yihui

This comment has been minimized.

Copy link
Owner

yihui commented Nov 1, 2017

@apreshill Actually I have completed all the work for you, and all I need from you is the contributor agreement, which should take you only a few seconds to fill out. Are you sure you want to give up?

@apreshill

This comment has been minimized.

Copy link
Contributor Author

apreshill commented Nov 1, 2017

User error- I completed the contributor agreement this afternoon, right before I closed the issue...perhaps I should try it again?

@yihui yihui reopened this Nov 1, 2017
@yihui

This comment has been minimized.

Copy link
Owner

yihui commented Nov 1, 2017

Oh, I didn't notice that. You are all set! Thanks!

@apreshill

This comment has been minimized.

Copy link
Contributor Author

apreshill commented Nov 1, 2017

Great thank you!

@yihui
yihui approved these changes Nov 2, 2017
@yihui yihui merged commit affd905 into yihui:master Nov 2, 2017
2 checks passed
2 checks passed
clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@yihui yihui mentioned this pull request Nov 2, 2017
3 of 3 tasks complete
@yihui

This comment has been minimized.

Copy link
Owner

yihui commented Nov 2, 2017

Here is how to use this theme:

output:
  xaringan::moon_reader:
    css: [default, rladies, rladies-fonts]
@apreshill apreshill deleted the apreshill:edit branch Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.