Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metropolis theme #86

Merged
merged 6 commits into from Nov 2, 2017
Merged

Add metropolis theme #86

merged 6 commits into from Nov 2, 2017

Conversation

@pat-s
Copy link
Collaborator

pat-s commented Oct 27, 2017

The theme does not work nicely with the default presentation as I modified slide margins left and right (less space) and changed the font-size of the body font.

I assume you would prefer that it plays nicely with the example presentation, right?
However, this would mean that I would need to change a lot of margins again - which I would try to avoid if possible.
The option of having a modified version of the original theme of my repo is also a bit ugly.
What are your thoughts on this?

---
title: "Presentation Ninja"
subtitle: "⚔<br/>with xaringan"
author: "Yihui Xie"
date: "2016/12/12"
output:
  xaringan::moon_reader:
    lib_dir: libs
    css: ["metropolis.css", "default"]
    nature:
      highlightStyle: github
      highlightLines: true
      countIncrementalSlides: false
---
pat-s added 4 commits Jan 19, 2017
remove `@details` tag in `moon_reader()` documentation
Merge branch 'master' of https://github.com/yihui/xaringan

# Conflicts:
#	R/render.R
@yihui

This comment has been minimized.

Copy link
Owner

yihui commented Oct 27, 2017

It is totally okay if it does not work well with the default example -- we could just add a new example to the package that works better with your theme. I'll take a closer look. Thanks for the contribution!

Copy link
Owner

yihui left a comment

I just tested this theme, and it looks great! Could you split the css file into two: metropolis.css and fonts-fira.css? That way, it will be easier for users to use your theme with other fonts. Thanks!

@pat-s

This comment has been minimized.

Copy link
Collaborator Author

pat-s commented Nov 1, 2017

Could you split the css file into two: metropolis.css and fonts-fira.css?

@yihui done!

@yihui
yihui approved these changes Nov 2, 2017
Copy link
Owner

yihui left a comment

Thanks!

@yihui yihui merged commit 3036b31 into yihui:master Nov 2, 2017
2 checks passed
2 checks passed
clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@yihui yihui mentioned this pull request Nov 2, 2017
3 of 3 tasks complete
@yihui

This comment has been minimized.

Copy link
Owner

yihui commented Nov 2, 2017

Please note that I renamed fonts-fira.css to metropolis-fonts.css: https://slides.yihui.name/xaringan/#34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.