test(upload): Add test for returning multiple uploaded files with different structures.

[terabytesoftw]

Q	A
Is bugfix?	✔️
New feature?	❌
Breaks BC?	❌

Summary by CodeRabbit

• Tests
  • Added a new test to verify correct handling and return of multiple uploaded files with different structures in requests.

[coderabbitai]

Walkthrough

A new test method was added to the PSR7RequestTest class to verify that the Request class correctly processes and returns uploaded files with various structural forms when using a PSR-7 request adapter. The test covers single files, nested arrays, and indexed arrays, ensuring correct type and structure handling.

Changes

File(s)	Change Summary
tests/http/PSR7RequestTest.php	Added a test method to validate handling of multiple uploaded files with different structures.

Estimated code review effort

2 (10–30 minutes)

Suggested labels

bug

Poem

🐇
In the warren of tests, a new path appears,
Checking files in arrays, with no hidden fears.
Single or nested, all structures in view—
The request now returns them, both old and new.
With every assertion, the code hops ahead,
Ensuring uploads work just as it’s said!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6441164 and 2819525.

📒 Files selected for processing (1)

• tests/http/PSR7RequestTest.php (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: terabytesoftw
PR: yii2-extensions/psr-bridge#6
File: tests/http/RequestTest.php:1536-1552
Timestamp: 2025-07-20T16:35:15.300Z
Learning: In the yii2-extensions/psr-bridge project, the base TestCase class already handles $_SERVER cleanup in setUp() and tearDown() methods (lines 28 and 32), so individual test methods that extend TestCase don't need manual $_SERVER restoration.

Learnt from: terabytesoftw
PR: yii2-extensions/psr-bridge#6
File: tests/http/RequestTest.php:1536-1552
Timestamp: 2025-07-20T16:35:15.300Z
Learning: In the yii2-extensions/psr-bridge project, the base TestCase class already handles $_SERVER cleanup in setUp() and tearDown() methods, so individual test methods that extend TestCase don't need manual $_SERVER restoration.

Learnt from: terabytesoftw
PR: yii2-extensions/psr-bridge#6
File: tests/http/RequestTest.php:1564-1578
Timestamp: 2025-07-20T16:33:57.457Z
Learning: The TestCase class in yii2-extensions/psr-bridge automatically handles $_SERVER superglobal cleanup by saving its original state before each test and restoring it afterward in setUp() and tearDown() methods. Manual $_SERVER cleanup in individual test methods is unnecessary when extending this TestCase.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: phpunit / PHP 8.1-ubuntu-latest
• GitHub Check: mutation / PHP 8.4-ubuntu-latest
• GitHub Check: phpunit / PHP 8.2-windows-latest

🔇 Additional comments (3)

tests/http/PSR7RequestTest.php (3)

668-680: LGTM: Proper file validation before test execution.

The file size validation using filesize() and assertions to ensure files exist is a good practice that prevents test failures due to missing test files.

---

682-693: Excellent test coverage for different file upload structures.

The test data setup comprehensively covers:

• Simple single files (simple1, simple2)
• Nested associative arrays (nested with level1, level2)
• Indexed arrays (array_files with numeric indices)

This ensures the PSR-7 to Yii2 conversion handles all common file upload scenarios correctly.

---

701-753: Comprehensive assertions validate file structure conversion.

The test method thoroughly validates:

• Top-level array count preservation
• Type checking for single files vs. arrays
• Nested structure integrity
• Correct UploadedFile instance creation

The detailed assertion messages provide clear debugging information if tests fail. The test ensures that the getUploadedFiles() method correctly maintains the original file hierarchy while converting PSR-7 uploaded files to Yii2 UploadedFile instances.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6441164) to head (2819525).
Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##                main       #16   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        99        99           
===========================================
  Files              6         6           
  Lines            252       252           
===========================================
  Hits             252       252           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.