Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter class directories #21

Merged
merged 6 commits into from
Mar 31, 2023
Merged

Filter class directories #21

merged 6 commits into from
Mar 31, 2023

Conversation

xepozz
Copy link
Member

@xepozz xepozz commented Jan 22, 2023

Q A
Is bugfix? ✔️
Fixed issues #18

@codecov
Copy link

codecov bot commented Jan 22, 2023 •
edited
Loading

Codecov Report

Patch coverage: 83.33% and project coverage change: -1.79 ⚠️

Comparison is base (943f181) 100.00% compared to head (b39dd51) 98.21%.

❗ Current head b39dd51 differs from pull request most recent head 8a8c1e6. Consider uploading reports for the commit 8a8c1e6 to get more accurate results

Additional details and impacted files 
@@              Coverage Diff              @@
##              master      #21      +/-   ##
=============================================
- Coverage     100.00%   98.21%   -1.79%     
- Complexity        19       22       +3     
=============================================
  Files              1        1              
  Lines             50       56       +6     
=============================================
+ Hits              50       55       +5     
- Misses             0        1       +1
Impacted Files Coverage Δ
src/Classifier.php 98.21% <83.33%> (-1.79%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xepozz xepozz requested a review from a team February 13, 2023 16:16
@xepozz xepozz added the status:code review The pull request needs review. label Feb 13, 2023
vjik
vjik reviewed Feb 13, 2023
View reviewed changes
Copy link
Member

@vjik vjik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, need tests. Potentially can be problem with directory separators / \

@xepozz xepozz merged commit 629e507 into master Mar 31, 2023
@xepozz xepozz deleted the filter-directory branch March 31, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjik vjik vjik left review comments

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xepozz @vjik