Skip to content

Add ColumnSchemaTest #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Jul 20, 2023

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

@what-the-diff
Copy link

what-the-diff bot commented Jul 20, 2023

PR Summary

  • Introduction of ColumnSchemaTest
    A new file, ColumnSchemaTest.php, has been added. This contains a comprehensive test suited specifically for the ColumnSchema class. This is expected to improve our test coverage and ensure the robustness of the mentioned class.

  • Column Name Modification in two files
    The time column name has been updated to timestamp_col, and this modification has been made in both the schemaProvider.php and oci.sql files. This new naming convention should increase clarity and reduce potential confusion, as it's more descriptive of its function.

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fdd6eb0) 98.29% compared to head (5097bd5) 98.29%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #228   +/-   ##
=========================================
  Coverage     98.29%   98.29%           
  Complexity      183      183           
=========================================
  Files            16       16           
  Lines           586      586           
=========================================
  Hits            576      576           
  Misses           10       10           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Tigrov Tigrov marked this pull request as ready for review July 20, 2023 17:23
@samdark samdark requested review from darkdef and terabytesoftw July 21, 2023 08:13
@samdark samdark merged commit 744eb43 into yiisoft:master Jul 24, 2023
@samdark
Copy link
Member

samdark commented Jul 24, 2023

👍

@Tigrov Tigrov deleted the add_column_schema_test branch August 4, 2023 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants