[Bug] All exceptions are caught for optional dependencies

[viktorprogger]

What steps will reproduce the problem?

Having the sample code:

class A
{
    public function __construct()
    {
        throw new RuntimeException('Something happened on initialization');
    }
}

class B
{
    public function __construct(private ?A $a = null)
    {
    }
}

$container->get(B::class);

What is the expected result?

The exception is thrown

What do you get instead?

Instance of B with a wrong dependency, and no exception is thrown. It' a hell to debug this situation.

Additional info

This code is responsible for the specified behavior. I'm pretty sure container definitions must not have a deal with application-level exceptions. In my opinion in the case when a dependency has a definition, and an exception is thrown on its resolving, this exception must not be catched by container/definition resolver, and doesn't matter if this dependency is optional or not.

[vjik]

Similar behaviour on resolving dependencies with union types:

definitions/src/ParameterDefinition.php

Lines 182 to 195 in 338af01

	try {
	/** @var mixed */
	$result = $container->get($typeName);
	if (!$result instanceof $typeName) {
	$actualType = $this->getValueType($result);
	throw new InvalidConfigException(
	"Container returned incorrect type \"$actualType\" for service \"$class\"."
	);
	}
	return $result;
	} catch (Throwable $t) {
	$error = $t;
	}

[vjik]

I'm try fix thid bug. Waiting changes in yiisoft/test-support: yiisoft/test-support#40

[samdark]

Do you need test-support tagged?

[vjik]

Also need make same fix for union types