Make DefinitionValidator::validateArrayDefinition() public and remove ParameterDefinition::isBuiltin()
#37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vjik
changed the title
DefinitionValidator::validateArrayDefinition() publicDefinitionValidator::validateArrayDefinition() public and remove ParameterDefinition::isBuiltin()
rustamwin
approved these changes
Jun 11, 2022
| if ($type === null) { | ||
| return false; | ||
| } | ||
| return $type->isBuiltin(); |
Member
There was a problem hiding this comment.
Have you considered keeping this method?
public function isBuiltin(): bool
{
$type = $this->parameter->getType();
if ($type === null) {
return false;
}
return !$this->isUnionType() && $type->isBuiltin();
}
Member
Author
There was a problem hiding this comment.
Have you considered keeping this method?
No. For union type method isBuiltin() doesn't make sense. I think that's why it was removed from ReflectionType.
samdark
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why remove
isBuiltin()?From PHP 8.0 method was removed from the
ReflectionTypeand available inReflectionNamedTypeonly.