Skip to content

Conversation

@vjik
Copy link
Member

@vjik vjik commented Oct 29, 2022

Q A
Is bugfix?
New feature? ✔️
Breaks BC? ✔️
Fixed issues -

Yii DI Container tests pass.

@what-the-diff
Copy link

what-the-diff bot commented Oct 29, 2022

  • Added autowiring for methods.
  • Improved variadic arguments support in method definitions: now it is possible to pass named argument with an array of values, not only indexed one; also added a check that the value passed as a named argument should be an array (previously there was no such check).

@codecov
Copy link

codecov bot commented Oct 29, 2022

Codecov Report

Base: 99.14% // Head: 98.94% // Decreases project coverage by -0.19% ⚠️

Coverage data is based on head (68b31d2) compared to base (69a5935).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #44      +/-   ##
============================================
- Coverage     99.14%   98.94%   -0.20%     
- Complexity      213      214       +1     
============================================
  Files            14       14              
  Lines           469      475       +6     
============================================
+ Hits            465      470       +5     
- Misses            4        5       +1     
Impacted Files Coverage Δ
src/Helpers/DefinitionResolver.php 100.00% <ø> (ø)
src/ArrayDefinition.php 100.00% <100.00%> (ø)
src/ParameterDefinition.php 95.41% <0.00%> (-0.89%) ⬇️
src/Helpers/Normalizer.php 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vjik vjik added the status:code review The pull request needs review. label Oct 29, 2022
@vjik vjik requested a review from a team October 29, 2022 08:16
@vjik vjik marked this pull request as ready for review October 29, 2022 08:18
Copy link
Member

@rustamwin rustamwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants