Skip to content

Conversation

@vjik
Copy link
Member

@vjik vjik commented Nov 1, 2022

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues partly #45

@what-the-diff
Copy link

what-the-diff bot commented Nov 1, 2022

  • Added a check of method name in array definitions.
  • Improved variadic arguments support for methods of array definitions and added autowiring to them.
  • Raised minimum PHP version to 8.0 and refactored code (removed unused variables, improved performance).

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (0d11339) compared to base (f21846c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##              master       #46   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       209       210    +1     
===========================================
  Files             14        14           
  Lines            455       458    +3     
===========================================
+ Hits             455       458    +3     
Impacted Files Coverage Δ
src/ArrayDefinition.php 100.00% <ø> (ø)
src/Helpers/DefinitionValidator.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vjik vjik requested a review from a team November 1, 2022 08:26
@vjik vjik added the status:code review The pull request needs review. label Nov 1, 2022
@vjik vjik merged commit c8b9004 into master Nov 2, 2022
@vjik vjik deleted the mutants branch November 2, 2022 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants