Skip to content

Conversation

@vjik
Copy link
Member

@vjik vjik commented Nov 2, 2022

Q A
Is bugfix?
New feature?
Breaks BC? ✔️
Fixed issues -

@what-the-diff
Copy link

what-the-diff bot commented Nov 2, 2022

  • Change result format of DefinitionStorage::getBuildStack() method to definition IDs array
  • Raise minimum PHP version to 8.0 and refactor code
  • In methods of array definitions add autowiring and improve variadic arguments support
  • In definition validator add a check of method name in array definitions

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (3485e6a) compared to base (38d02d9).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##              master       #49   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       208       208           
===========================================
  Files             14        14           
  Lines            457       457           
===========================================
  Hits             457       457           
Impacted Files Coverage Δ
src/DefinitionStorage.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vjik vjik requested a review from a team November 2, 2022 08:36
@vjik vjik added the status:code review The pull request needs review. label Nov 2, 2022
@vjik vjik merged commit bf5bc2a into master Nov 3, 2022
@vjik vjik deleted the build-stack branch November 3, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants