Skip to content

Conversation

@vjik
Copy link
Member

@vjik vjik commented Nov 8, 2022

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues -

@what-the-diff
Copy link

what-the-diff bot commented Nov 8, 2022

  • Added test for magic methods.
  • Fixed error on use in array definition methods that should be work via magic __call() method (@vjik)

@vjik vjik requested a review from a team November 8, 2022 08:36
@vjik vjik added the status:code review The pull request needs review. label Nov 8, 2022
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (8b36489) compared to base (eb225cd).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##              master       #53   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       210       211    +1     
===========================================
  Files             14        14           
  Lines            458       460    +2     
===========================================
+ Hits             458       460    +2     
Impacted Files Coverage Δ
src/ArrayDefinition.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vjik vjik merged commit 51044c9 into master Nov 8, 2022
@vjik vjik deleted the fix branch November 8, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants