Skip to content

Cleanup validateResolver result#31

Merged
samdark merged 7 commits into
yiisoft:masterfrom
olegbaturin:cleanup-validateResolver-result
Sep 27, 2025
Merged

Cleanup validateResolver result#31
samdark merged 7 commits into
yiisoft:masterfrom
olegbaturin:cleanup-validateResolver-result

Conversation

@olegbaturin
Copy link
Copy Markdown
Contributor

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

Cleaup ValidateResolver::result after hydration

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (400bd64) to head (b111cde).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##              master       #31   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        20        20           
===========================================
  Files              4         4           
  Lines             53        54    +1     
===========================================
+ Hits              53        54    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samdark samdark requested a review from vjik September 16, 2025 18:06
Comment thread tests/ValidatingHydratorTest.php Outdated
@samdark samdark changed the title cleaup validateResolver result Cleanup validateResolver result Sep 22, 2025
Comment thread CHANGELOG.md Outdated
@vjik vjik requested a review from a team September 26, 2025 14:16
@vjik vjik added the status:code review The pull request needs review. label Sep 26, 2025
Copy link
Copy Markdown
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@samdark samdark merged commit 42c9789 into yiisoft:master Sep 27, 2025
26 checks passed
@samdark
Copy link
Copy Markdown
Member

samdark commented Sep 27, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants