Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative groups implementation #14

Merged
merged 16 commits into from Dec 9, 2019
Merged

Alternative groups implementation #14

merged 16 commits into from Dec 9, 2019

Conversation

@samdark
Copy link
Member

samdark commented Dec 3, 2019

Q A
Is bugfix?
New feature?
Breaks BC? ✔️
Tests pass? ?
Fixed issues #5 See yiisoft/router-fastroute#9
samdark added 2 commits Dec 3, 2019
@samdark samdark added this to the 1.0.0-alpha1 milestone Dec 3, 2019
@samdark samdark requested a review from yiisoft/reviewers Dec 3, 2019
samdark added 7 commits Dec 4, 2019
src/Group.php Outdated Show resolved Hide resolved
src/Route.php Outdated Show resolved Hide resolved
src/Route.php Outdated Show resolved Hide resolved
src/Route.php Outdated Show resolved Hide resolved
src/RouterFactory.php Outdated Show resolved Hide resolved
samdark and others added 4 commits Dec 5, 2019
Co-Authored-By: Rustam Mamadaminov <rmamdaminov@gmail.com>
Co-Authored-By: Rustam Mamadaminov <rmamdaminov@gmail.com>
Co-Authored-By: Rustam Mamadaminov <rmamdaminov@gmail.com>
Co-Authored-By: Rustam Mamadaminov <rmamdaminov@gmail.com>
@samdark samdark requested a review from yiisoft/reviewers Dec 5, 2019
samdark and others added 3 commits Dec 5, 2019
Co-Authored-By: Rustam Mamadaminov <rmamdaminov@gmail.com>
@samdark samdark mentioned this pull request Dec 9, 2019
@samdark samdark merged commit 383a4e4 into master Dec 9, 2019
5 checks passed
5 checks passed
Scrutinizer Analysis: 1 new issues, 20 updated code elements – Tests: passed
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/styleci/push The analysis has passed
Details
@samdark samdark deleted the groups-alternative branch Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.