Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added groups #3

Merged
merged 20 commits into from Dec 2, 2019
Merged

Added groups #3

merged 20 commits into from Dec 2, 2019

Conversation

@samdark
Copy link
Member

samdark commented May 28, 2019

Q A
Is bugfix? no
New feature? yes
Breaks BC? no
Tests pass? yes
Fixed issues #1
src/Group.php Show resolved Hide resolved
src/Group.php Show resolved Hide resolved
samdark added 6 commits Nov 30, 2019
@samdark samdark marked this pull request as ready for review Nov 30, 2019
@samdark samdark requested a review from yiisoft/reviewers Nov 30, 2019
# Conflicts:
#	tests/MatchingResultTest.php
#	tests/Middleware/RouterTest.php
#	tests/RouteTest.php
@xepozz
xepozz approved these changes Nov 30, 2019
Copy link
Contributor

xepozz left a comment

looks good

Copy link
Contributor

xepozz left a comment

There is need to expose $prefix variable

@rustamwin

This comment has been minimized.

Copy link
Member

rustamwin commented Nov 30, 2019

No support middleware for the group?

samdark added 2 commits Nov 30, 2019
@samdark

This comment has been minimized.

Copy link
Member Author

samdark commented Nov 30, 2019

samdark added 4 commits Nov 30, 2019
@samdark samdark requested a review from yiisoft/reviewers Nov 30, 2019
samdark added 2 commits Nov 30, 2019
@samdark samdark added this to the 1.0.0-alpha1 milestone Dec 2, 2019
src/Group.php Outdated Show resolved Hide resolved
src/Group.php Outdated Show resolved Hide resolved
src/Group.php Outdated Show resolved Hide resolved
samdark and others added 2 commits Dec 2, 2019
Co-Authored-By: Dmitriy Derepko <xepozz@list.ru>
Co-Authored-By: Dmitriy Derepko <xepozz@list.ru>
Co-Authored-By: Dmitriy Derepko <xepozz@list.ru>
@samdark samdark merged commit 00f66f0 into master Dec 2, 2019
5 checks passed
5 checks passed
Scrutinizer Analysis: 11 updated code elements – Tests: passed
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/styleci/push The analysis has passed
Details
@samdark samdark deleted the route-groups branch Dec 2, 2019
@zabachok

This comment has been minimized.

Copy link

zabachok commented Dec 19, 2019

@samdark why you don't use typed properties?

@samdark

This comment has been minimized.

Copy link
Member Author

samdark commented Dec 19, 2019

Was no time to convert to these in this case. Do you want to help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.