Skip to content

Add custom callback and change default behaviour for SimpleContainer::has() #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vjik merged 5 commits into from
Mar 20, 2022
Merged

Add custom callback and change default behaviour for SimpleContainer::has() #40

vjik merged 5 commits into from
Mar 20, 2022

Conversation

@vjik
Copy link
Member

@vjik vjik commented Mar 19, 2022

Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ✔️
Fixed issues -

@vjik vjik requested a review from a team March 19, 2022 05:39
@vjik vjik added the status:code review The pull request needs review. label Mar 19, 2022
@vjik vjik mentioned this pull request Mar 19, 2022
Closed
@xepozz
Copy link
Member

xepozz commented Mar 19, 2022

Why do we need the hasCallback parameter?

@vjik
Copy link
Member Author

vjik commented Mar 19, 2022

Why do we need the hasCallback parameter?

My use case: test dependency that throws exception. has() in my case should return true.

@vjik vjik merged commit e23e7b5 into master Mar 20, 2022
@vjik vjik deleted the container branch March 20, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roxblnfk roxblnfk roxblnfk approved these changes

+1 more reviewer

@devanych devanych devanych approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status:code review The pull request needs review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vjik @xepozz @roxblnfk @devanych